add custom integer playback speed to live view video player#245
Closed
ehfeng wants to merge 1 commit into
Closed
Conversation
Adds a numeric input control to the video controls bar that lets users set the player's playbackRate to any integer >= 1, removing the prior implicit 2x cap from the native browser controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a numeric input on the live-view video controls bar so users can set any positive integer playback speed (1x, 2x, 3x, 5x, 10x, …), removing the implicit 2x cap that came from the native browser controls.
Test plan