Add batched POST /chromium/configure with optional start_url#244
Draft
hiroTamada wants to merge 2 commits into
Draft
Add batched POST /chromium/configure with optional start_url#244hiroTamada wants to merge 2 commits into
hiroTamada wants to merge 2 commits into
Conversation
Single multipart request can apply display, policies, flags, extensions, and profile changes with one Chromium restart, then navigate via CDP after DevTools is ready. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop DETACHED run-docker mode, the powerset runner script, and related AGENTS.md notes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /chromium/configure: one multipart request to batch display sizing, Chrome policies, Chromium flags, profile archive, extensions, and optionalstart_urlnavigation after a single Chromium restart.cdpclient.NavigateFirstPagefor post-readyPage.navigate(flattened CDP session, waits for load /domcontentloaded). Fixes concurrent WebSocket reads that caused flaky navigate failures.applyExtensionZipItemsused by configure and existing upload-and-restart.start_urltests; local runner script andDETACHED=1headlessrun-docker.shfor manual API use.make test: e2e package timeout raised to 120m (full suite exceeds default 10m).Test plan
go vet ./...and unit tests (go testexcluding/e2e)./scripts/run-local-chromium-configure-powerset.sh(31 permutations + start_url variants) against locally built headless imagego test -race -timeout 120m ./e2e/withE2E_CHROMIUM_HEADLESS_IMAGE/E2E_CHROMIUM_HEADFUL_IMAGEpointing at images built from this branchMade with Cursor