Closed
Conversation
…)" This reverts commit 033ec7d.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| --mount=type=cache,target=/var/lib/apt,sharing=locked,id=$CACHEIDPREFIX-apt-lib \ | ||
| apt update -y && \ | ||
| apt -y install chromium && \ | ||
| CHROMIUM_PKG_VERSION="$(apt-cache madison chromium | awk -v v="$CHROME_VERSION" '$3 ~ ("^" v) { print $3; exit }')" && \ |
There was a problem hiding this comment.
Awk regex prefix match may select wrong Chromium version
Low Severity
The awk pattern $3 ~ ("^" v) performs a prefix match using CHROME_VERSION as a regex. This has two issues: dots are unescaped regex wildcards (matching any character), and the lack of a version boundary means 145.0.7632.75 also matches versions like 145.0.7632.750. If a longer-prefixed version exists in the PPA and is selected, the installed Chromium would not match the ChromeDriver downloaded with the exact CHROME_VERSION, causing a silent version mismatch.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes Docker build logic to pin/install specific Chromium and matching ChromeDriver versions; builds may fail if the requested version isn’t available in the PPA or the download URL changes.
Overview
Ensures the headful and headless Chromium images are built with a single, consistent
CHROME_VERSIONby selecting the exactchromiumpackage version viaapt-cache madisonand failing fast if it can’t be found.Updates ChromeDriver installation to download the driver for that same
CHROME_VERSION, removing the separate hardcodedCHROMEDRIVER_VERSIONto avoid Chromium/driver mismatches.Written by Cursor Bugbot for commit 11dbef6. This will update automatically on new commits. Configure here.