Repository navigation
fix: report missing EROFS dependency - #598
Open
dominikpalatynski wants to merge 1 commit into
Open
dominikpalatynski wants to merge 1 commit into
dominikpalatynski wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While trying out Hypeman and creating a VM from an image, I encountered an error caused by a missing dependency:
The installer had reported success, so I think it would be helpful to notify users earlier, during installation. This PR checks for
mkfs.erofsin the Linux installer and adds an actionable error message when image conversion cannot find it. Both errors explain how to installerofs-utilson Ubuntu/Debian.Evidence
TestExportRootfsWithContextMissingErofsToolpasses. A direct exporter smoke run reports the missing tool andsudo apt-get install erofs-utils, while preservingexec.ErrNotFound.Checks run: