Resume paused instances on restore requests - #489
Merged
Merged
Conversation
sjmiller609
marked this pull request as ready for review
October 1, 2026 19:51
chruffins
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
Medium Risk
Changes VM lifecycle restore behavior and hypervisor resume/caching under lock; mistakes could leave paused VMs stuck or double-resume, though tests cover concurrency and retry paths.
Overview
Restore requests no longer fail when the instance is paused with an existing VMM. Instead of falling through to standby restore (which rejects non-standby states),
RestoreInstancenow resumes the live hypervisor under the per-instance lock, refreshes cached hypervisor state, and emitsLifecycleEventRestoreon success.On resume failure, cached hypervisor state is invalidated so a later restore can retry. Running and initializing instances remain a no-op, and the full standby snapshot restore path is unchanged.
New tests cover resume success for running/initializing metadata targets, unchanged on-disk metadata, failed-then-success retry, idempotent second restores, and concurrent restores invoking Resume only once.
Reviewed by Cursor Bugbot for commit 2653831. Bugbot is set up for automated code reviews on this repo. Configure here.