Skip to content

Fix tc class EEXIST error during TAP device creation #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sjmiller609 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Draft

Fix tc class EEXIST error during TAP device creation #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/network/bridge_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,8 +705,11 @@ func (m *manager) addVMClass(bridgeName, tapName string, rateBps, ceilBps int64)
}
ceilStr := formatTcRate(ceilBps)

// 1. Add HTB class for this VM
cmd := exec.Command("tc", "class", "add", "dev", bridgeName, "parent", htbRootClassID,
// 1. Add or update HTB class for this VM
// Use "replace" instead of "add" for idempotency — if the class already exists
// (e.g., orphaned from a previous failed cleanup, or a 16-bit hash collision on
// restore), "replace" updates it in place instead of failing with EEXIST.
cmd := exec.Command("tc", "class", "replace", "dev", bridgeName, "parent", htbRootClassID,
"classid", fullClassID, "htb", "rate", rateStr, "ceil", ceilStr, "prio", "1")
cmd.SysProcAttr = &syscall.SysProcAttr{
AmbientCaps: []uintptr{unix.CAP_NET_ADMIN},
Expand Down
Loading