Execute Harbor commands with Bash - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
shset -o pipefailvalidation
uv run ruff format --check .uv run ruff check .uv run ty checkuv run pytest(13 passed)uv buildcontext
A provider-backed Harbor evaluation reached agent setup but failed before dispatch because Debian's
/bin/shrejected Harbor's Bashpipefailpreamble.Note
Low Risk
Narrow change to the shell wrapper for
exec; low risk unless images lack Bash or scripts assumed strict POSIXshsemantics.Overview
Hypeman
execnow invokes/bin/bash -lcinstead of/bin/sh -lcwhen running commands in the instance (workdir setup, agent commands, etc.).This aligns remote execution with Harbor/agent setup scripts that rely on Bash features such as
set -o pipefail, which Debian’s/bin/sh(dash) rejects and was breaking evaluations before dispatch.Unit tests that assert the
exec_asyncargv were updated to expect Bash; instance idle loop entrypoint andsu … -s /bin/shbehavior are unchanged.Reviewed by Cursor Bugbot for commit 8622acd. Bugbot is set up for automated code reviews on this repo. Configure here.