EOL persistent browsers#167
Merged
Merged
Conversation
Drop the --persistent-id flag (deprecated), the Persistent ID list column, the PersistenceID input field and Persistence param plumbing on create, the persistent_id delete fallback, and the persistence arg on printBrowserSessionResult / buildBrowserTableData. Persistent browsers are EOL'd in the API. Part of EOL persistent browsers (KERNEL-1015). Co-authored-by: Cursor <cursoragent@cursor.com>
…thod Remove the deprecated BrowsersService.Delete method (DELETE /browsers ?persistent_id=) from the interface and fake, and drop all Persistence fixture data and assertions from browsers_test.go. Part of EOL persistent browsers (KERNEL-1015). Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the flag, the MaxPersistentSessions input field, the cap-setting plumbing, the "Max Persistent Sessions" limits row, and the matching test fixture field. The cap is moot once persistent browsers are EOL. Part of EOL persistent browsers (KERNEL-1015). Co-authored-by: Cursor <cursoragent@cursor.com>
After dropping the persistent-id fallback there's only one possible error, so the nonNotFoundErrors slice was just noise. Collapse to a direct check. Part of EOL persistent browsers (KERNEL-1015). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR title 'EOL persistent browsers' does not indicate changes to kernel API endpoints or Temporal workflows; please confirm if this affects packages/api/cmd/api/ or packages/api/lib/temporal and opt in manually if needed. To monitor this PR anyway, reply with |
masnwilliams
approved these changes
May 19, 2026
Contributor
masnwilliams
left a comment
masnwilliams
left a comment
There was a problem hiding this comment.
reviewed — clean EOL pass :bufo-approves:
Nits
cmd/browsers_test.go— no coverage for theutil.IsNotFoundbranch inDelete(pre-existing gap, not a regression).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Removes previously supported (and partially backward-compatible) persistent browser session identifiers and project limit flags, which can break existing CLI scripts relying on
--persistent-idor--max-persistent-sessions. Core changes are localized to CLI wiring and output formatting.Overview
EOLs persistent browser sessions in the CLI. The
browserscommands drop the deprecated persistent-session path:--persistent-idis removed, create no longer sends persistence params, list/get output no longer shows “Persistent ID”, and delete now only callsDeleteByID(no fallback delete-by-persistent-id).Removes persistent-session project limits.
projects limitsno longer exposes--max-persistent-sessionsand stops rendering that limit in table output; tests are updated accordingly.Reviewed by Cursor Bugbot for commit c2440d4. Bugbot is set up for automated code reviews on this repo. Configure here.