fix(sqs-samples): add /healthz for replay readiness gating#236
Open
slayerjain wants to merge 1 commit into
Open
fix(sqs-samples): add /healthz for replay readiness gating#236slayerjain wants to merge 1 commit into
slayerjain wants to merge 1 commit into
Conversation
The sqs-localstack e2e step replays with a fixed --delay; under CI resource pressure the app + its mongo/localstack deps can take longer than that to start, so replayed requests hit a not-yet-serving app and fail with "status_code got=0" (a flaky enterprise CI step). The app exposed no 2xx GET endpoint to poll — only GET /:param (redirect/404) and POST /url. Add a static GET /healthz returning 200; gin prioritises it over the "/:param" wildcard. The replay driver can now gate on real readiness (keploy --health-url) instead of a fixed delay. Recording is unaffected (the route is never exercised during record). Signed-off-by: slayerjain <shubhamkjain@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 2xx GET /healthz to the sqs sample so the keploy enterprise CI's sqs-localstack replay can gate on real app readiness (--health-url) instead of a fixed --delay — fixing the flaky 'status_code got=0' failures when the app/localstack cold-start exceeds the delay under contention. Recording unaffected (route not exercised during record). Pairs with the enterprise sqs-localstack.sh --health-url change.