fix(web): show navigation on homepage - #244
Conversation
kellnerd
left a comment
There was a problem hiding this comment.
The navigation bar is intentionally hidden on the landing page:
- 3 out of 4 links are useless, their content is already available on the landing page.
- It looks a bit ugly to have a navigation bar with a small logo directly above the banner with the big logo.
Originally it was also intended that the (advanced) Settings are not visible for first time users, but admittedly I've found myself often navigating from the landing page -> About -> Settings, since I usually want to change settings before initiating a lookup.
So I agree that it makes sense to link to Settings directly from home, but as long as there is only one useful navigation bar item, I would rather show the link elsewhere.
I always wanted to have a short explanation ("How does it work?" / "About Harmony") at the end of the landing page, which would be a good fit for a prominent link to the settings.
Maybe we can start with an info message box "Did you know that you can customize Harmony’s behavior?" where customize is a link to the settings.
|
Alternatively we could modify the navigation bar conditionally to hide at least the initial "Harmony" link with the logo on the landing page.
What do people think? @afrocatmusic and @Aerozol |
|
Hmm, I know the links are redundant but I do think it's consistent and 'reassuring' to have the same nav bar at the top. We are creatures of habit. |

Summary
Fixes #230
Validation
deno task okdeno test -RE— 38 tests / 617 steps passeddeno task build— 8 routes / 5 islands built/and/settingsreturn 200, and/contains the/settingslink