fix: reject hashes containing NUL bytes in compare#1225
Open
abhu85 wants to merge 1 commit intokelektiv:masterfrom
Open
fix: reject hashes containing NUL bytes in compare#1225abhu85 wants to merge 1 commit intokelektiv:masterfrom
abhu85 wants to merge 1 commit intokelektiv:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject bcrypt hashes containing NUL bytes (
\x00) incompare()andcompareSync()to prevent non-canonical hash validation.Problem
When a hash string contains a NUL byte, the native C++ binding truncates at the first
\x00(viac_str()), causing non-canonical hashes likevalidHash + "\x00extra"to validate against the password. This is a security concern as it allows hash manipulation.Solution
Add input validation in
compare()andcompareSync()to reject hash strings containing NUL bytes before passing to the native binding.Test Plan
compare(pw, hash + "\x00extra")rejectscompareSync(pw, hash + "\x00extra")rejectsFixes #1224