fix: keep terminal prompts on fresh lines - #79
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized, match the linked issue’s acceptance criteria, and include targeted E2E coverage for the new prompt/newline behavior.
Pull request overview
This PR improves the terminal UI layer by making prompt redraws newline-aware, ensuring prompts never concatenate with existing visible output, and aligns clear-screen behaviors across UI/keyboard paths. It also bumps the extension version to reflect the fix release.
Changes:
- Track whether the current terminal line already has visible content and prepend
CRLFbefore writing a new prompt when needed. - Unify clear-screen behavior via
clearScreen(), making Clear/Ctrl+K discard typed input and Ctrl+L preserve it while redrawing the prompt cleanly. - Add E2E coverage for prompt newline restoration and clear behavior; bump version from
0.4.6to0.4.7.
File summaries
| File | Description |
|---|---|
| src/ui/terminal.js | Adds newline-aware prompt rendering and consolidated clear-screen logic with line-state tracking. |
| scripts/e2e-terminal-stop.test.mjs | Adds E2E assertions for clear behavior and prompt restoration after newline-less output. |
| package.json | Bumps extension/package version to 0.4.7. |
| package-lock.json | Updates lockfile version fields to 0.4.7. |
| manifest.json | Updates extension manifest version to 0.4.7. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #78