fix(firefox): add buffered stdin fallback - #54
Merged
Conversation
Validate discriminated stdin modes at the worker boundary and let the WASI shim consume pre-supplied bytes with deterministic EOF. Preserve the existing SharedArrayBuffer path for interactive input.\n\nRefs #53
Make run preparation asynchronous and keep toolbar and terminal state consistent across submit, cancellation, duplicate actions, and failures. Add an accessible size-limited dialog while preserving Chromium live stdin.\n\nRefs #53
Treat Firefox compile and run as supported when SharedArrayBuffer is absent, remove unsupported isolation keys from Firefox manifests, and document the exact runtime acceptance required for cin.\n\nRefs #53
Share the 256 KiB contract between the UI and worker validator, reject oversized payloads at the worker boundary, and isolate dialog orchestration from terminal run state. Add regression coverage for oversized requests and the textarea cap.
Advance the manifest-driven project version for the Firefox buffered-stdin release PR and keep package metadata synchronized.
Owner
Author
|
Version bump applied and pushed in commit Validation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interactive/buffered/nonestdin contractImplementation follows the revised plan in issue #53: #53 (comment)
Validation
npm run test:e2e— 163 passednpm run lint— passednpm run build— passed; existing webpack bundle-size warnings onlynpm run test:browser:firefox— passed packaging andweb-ext lint(15 existing warnings)npm audit --audit-level=high— reports 6 existing transitive advisories (1 moderate, 5 high); this change adds no dependencies and complete remediation includes a breakingcopy-webpack-pluginupgradeBrowser QA still required
docs/firefox-stdin-runtime-acceptance.mdin a real Firefox extension context and paste the requested evidence here.npm run test:browser:chromeloaded the extension and WASM toolchain but did not reach the harness completion condition before timing out; Chromium behavior is otherwise covered by capability and run-contract regression tests.Closes #53