fix(release): upload nested Firefox release assets - #47
Merged
Conversation
Collect regular files recursively before invoking the GitHub CLI so the signed Firefox XPI directory is not passed as an upload argument. Add a workflow regression guard and document the nested asset layout.
kbuffardi
marked this pull request as ready for review
July 28, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the GitHub release workflow so it uploads the signed Firefox unlisted XPI.
Root cause
The workflow passed
release/*directly togh release uploadandgh release create. Once Firefox signing createdrelease/firefox-unlisted/, that glob expanded to a directory, which the GitHub CLI rejected.Changes
release/before publishing assets.Validation
npm run lintnpm run buildnpm run test:e2ebash -nworkflow shell blockgit diff --checkThe pre-existing untracked spec files in the worktree were intentionally not included.