Use PUT instead of PATCH in Attachment::update()

Author: Art4

src/Redmine/Api/Attachment.php

@@ -64,15 +64,17 @@ public function show($id)
      */
     final public function update(int $id, array $params): bool
     {
+        // we are using `PUT` instead of `PATCH`
+        // @see https://github.com/kbsali/php-redmine-api/pull/395#issuecomment-2004089154
         $this->lastResponse = $this->getHttpClient()->request(HttpFactory::makeJsonRequest(
-            'PATCH',
+            'PUT',
             '/attachments/' . $id . '.json',
             JsonSerializer::createFromArray(['attachment' => $params])->getEncoded()
         ));
 
-        // if ($this->lastResponse->getStatusCode() !== 204) {
-        //     throw UnexpectedResponseException::create($this->lastResponse);
-        // }
+        if ($this->lastResponse->getStatusCode() !== 204) {
+            throw UnexpectedResponseException::create($this->lastResponse);
+        }
 
         return true;
     }

tests/Unit/Api/Attachment/UpdateTest.php

@@ -21,7 +21,7 @@ public function testUpdateReturnsCorrectResponse($id, array $params, $expectedPa
         $client = AssertingHttpClient::create(
             $this,
             [
-                'PATCH',
+                'PUT',
                 $expectedPath,
                 'application/json',
                 $expectedContent,
@@ -59,7 +59,7 @@ public function testUpdateThrowsUnexpectedResponseException()
         $client = AssertingHttpClient::create(
             $this,
             [
-                'PATCH',
+                'PUT',
                 '/attachments/5.json',
                 'application/json',
                 '{"attachment":[]}',