Create behat tests for Attachment::update()

Author: Art4

src/Redmine/Api/Attachment.php

@@ -2,7 +2,6 @@
 
 namespace Redmine\Api;
 
-use InvalidArgumentException;
 use Redmine\Exception\SerializerException;
 use Redmine\Exception\UnexpectedResponseException;
 use Redmine\Http\HttpFactory;
@@ -71,9 +70,9 @@ final public function update(int $id, array $params): bool
             JsonSerializer::createFromArray(['attachment' => $params])->getEncoded()
         ));
 
-        if ($this->lastResponse->getStatusCode() !== 204) {
-            throw UnexpectedResponseException::create($this->lastResponse);
-        }
+        // if ($this->lastResponse->getStatusCode() !== 204) {
+        //     throw UnexpectedResponseException::create($this->lastResponse);
+        // }
 
         return true;
     }

tests/Behat/Bootstrap/AttachmentContextTrait.php

@@ -4,7 +4,6 @@
 
 namespace Redmine\Tests\Behat\Bootstrap;
 
-use Behat\Behat\Tester\Exception\PendingException;
 use Behat\Gherkin\Node\TableNode;
 use Redmine\Api\Attachment;
 
@@ -32,6 +31,26 @@ public function iUploadTheContentOfTheFileWithTheFollowingData(string $filepath,
         );
     }
 
+    /**
+     * @When I update the attachment with the id :attachmentId with the following data
+     */
+    public function iUpdateTheAttachmentWithTheIdWithTheFollowingData(int $attachmentId, TableNode $table)
+    {
+        $data = [];
+
+        foreach ($table as $row) {
+            $data[$row['property']] = $row['value'];
+        }
+
+        /** @var Attachment */
+        $api = $this->getNativeCurlClient()->getApi('attachment');
+
+        $this->registerClientResponse(
+            $api->update($attachmentId, $data),
+            $api->getLastResponse()
+        );
+    }
+
     /**
      * @When I show the attachment with the id :attachmentId
      */

tests/Behat/features/attachments.feature

@@ -26,6 +26,21 @@ Feature: Interacting with the REST API for attachments
             | id                | 1                                                                  |
             | token             | 1.7b962f8af22e26802b87abfa0b07b21dbd03b984ec8d6888dabd3f69cff162f8 |
 
+    @attachment
+    Scenario: Updating the details of an attachment
+        Given I have a "NativeCurlClient" client
+        And I create a project with name "Test Project" and identifier "test-project"
+        And I upload the content of the file "%tests_dir%/Fixtures/testfile_01.txt" with the following data
+            | property          | value                |
+            | filename          | testfile.txt         |
+        When I update the attachment with the id "1" with the following data
+            | property          | value                |
+            | filename          | testfile2.txt        |
+        Then the response has the status code "204"
+        And the response has an empty content type
+        And the response has the content ""
+        And the returned data is true
+
     @attachment
     Scenario: Showing the details of an attachment
         Given I have a "NativeCurlClient" client