feat: Add Transaction input/output helper methods and extreme tx test#176
Open
JAGADISHSUNILPEDNEKAR wants to merge 1 commit intokarask:masterfrom
Open
feat: Add Transaction input/output helper methods and extreme tx test#176JAGADISHSUNILPEDNEKAR wants to merge 1 commit intokarask:masterfrom
JAGADISHSUNILPEDNEKAR wants to merge 1 commit intokarask:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements helper methods for the
Transactionclass to simplify input and output management, addressing several TODO items. It also adds a new test case for transactions with a large number of outputs to verify serialization limits.Changes
add_input,update_input,remove_inputadd_output,update_output,remove_outputadd_inputautomatically adds an empty witness whenhas_segwitis True, keeping the lists synchronized.Motivation
Verification
tests/test_transaction_helpers.pyandtests/test_extreme_txs.py.python -m unittest discover tests/and all 103 tests passed.