TODO : Implement Unified Address Object for Multi-Type Address Support#149
Open
JAGADISHSUNILPEDNEKAR wants to merge 1 commit intokarask:masterfrom
Open
TODO : Implement Unified Address Object for Multi-Type Address Support#149JAGADISHSUNILPEDNEKAR wants to merge 1 commit intokarask:masterfrom
JAGADISHSUNILPEDNEKAR wants to merge 1 commit intokarask:masterfrom
Conversation
Contributor
Author
|
HI @karask |
Owner
|
Not sure that a unified object is required. The TODO mentions that but it was meant to generalise the existing Address object and see how to clean it up. I feel like this change adds more complexity for the user. I will keep it here and re-examine it later. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified Address Object Implementation
This PR introduces a new UnifiedAddress class that provides a unified way to handle all Bitcoin address types (P2PKH, P2SH, P2WPKH, P2WSH, P2TR) and enables conversion between compatible address types.
Changes:
address.pymodule with theUnifiedAddressclassKey Features:
Example Usage:
All the tests pass
