Add signature hash annex support as per BIP-341#128
Closed
JAGADISHSUNILPEDNEKAR wants to merge 2 commits intokarask:masterfrom
Closed
Add signature hash annex support as per BIP-341#128JAGADISHSUNILPEDNEKAR wants to merge 2 commits intokarask:masterfrom
JAGADISHSUNILPEDNEKAR wants to merge 2 commits intokarask:masterfrom
Conversation
Contributor
Author
Owner
|
Contributor
Author
|
@karask will go through this again along with your feedback and give you a enhanced approach over this |
Contributor
Author
|
Hey @karask there were some issues regarding this PR so I created a new PR #153 with the same implementation that you required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR introduces support for the signature hash annex in the signature hashing function, ensuring compatibility with transactions that include an annex field. The changes are minimal and scoped specifically to this functionality, avoiding any unnecessary modifications to unrelated components.
Key Changes
Relevance to PSBT Support
Implementing annex support in the signature hash function is a crucial step toward full Partially Signed Bitcoin Transaction (PSBT) support. This enhances PSBT compatibility with Taproot transactions by allowing correct sighash computation for inputs that include an annex, ensuring interoperability with modern Bitcoin wallets and signing tools.
Context
This PR keeps changes minimal while improving Bitcoin transaction handling in line with the latest standards, specifically addressing the requirements outlined in BIP-341 for signature hash computation.
Testing
Notes
Minimal code changes focused solely on implementing annex support in signature hash computation.