Skip to content

review: honor KAI_GRAPH=off for the planner context injection - #218

Draft
jschatz1 wants to merge 1 commit into
mainfrom
feat/symbol-call-edges
Draft

jschatz1 wants to merge 1 commit into
mainfrom
feat/symbol-call-edges

Conversation

@jschatz1

@jschatz1 jschatz1 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Why

KAI_GRAPH=off (graph.Disabled, kaicontext/kai-engine#128) turns off the harness graph summary, the graph tools and kai_grep's symbol route. The review command builds one more graph-derived block itself — the planner's turn-0 injected context — so it now checks the same switch. With it a whole review runs without the semantic graph, which is what a graph-on vs graph-off comparison needs. Default behaviour is unchanged.

The experimental callers-of-changed-code block (KAI_REVIEW_BLAST_CONTEXT) that was in this PR has been removed: on the benchmark it showed no gain over graph-on (F1 −0.6 Opus, +1.1 Sonnet, −4.9 GPT, n=45).

Status — ready once the engine release lands

Compiles only against the kai-engine release carrying #128 (graph.Disabled). After kai-core#9 → kai-engine#128 → kai-core v0.1.3 tag, the cascade's adopt-engine bump lands on main; rebase this on it and CI goes green.

Tests

go vet ./cmd/kai + go test ./... green against local engine/core.

🤖 Generated with Claude Code

KAI_GRAPH=off (graph.Disabled, kai-engine#128) already turns off the
harness graph summary, the graph tools and kai_grep's symbol route. The
review command builds one more graph-derived block itself — the planner's
injected context — so it now checks the same switch. With it the whole
review runs without the semantic graph, which is what a graph-on vs
graph-off comparison needs.

Requires the kai-engine release that carries graph.Disabled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jschatz1
jschatz1 force-pushed the feat/symbol-call-edges branch from 3fd3001 to 71b3d17 Compare October 29, 2026 13:03
@jschatz1 jschatz1 changed the title review: honor KAI_GRAPH=off; experimental callers-of-changed-code block review: honor KAI_GRAPH=off for the planner context injection Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant