Repository navigation
[Automated] Draft docs (kagent): fix(api): reject unsupported Harness workload overrides - #733
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
… workload overrides Signed-off-by: GitHub Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3616 — fix(api): reject unsupported Harness workload overrides
Docs versions:
mainWhat changes for users: Harness admission now rejects
spec.workload.commandandspec.workload.argsonclaudeandcodexharnesses. The API server also rejects an emptycommandorargslist on any Harness.What the docs now say: The Agent harness and Bring your own agent pages now say that
workload.commandandworkload.argsare supported onkagentandbyoharnesses, and rejected onclaudeandcodexharnesses.How
kagent-3616was draftedPlan, and what changed it
workload.commandandworkload.args.workload.commandonly forbyo, so it was not stale;agent-harness.mdandbring-your-own-agent.mdhad the stale claims.Why a documentation change is necessary
The pull request changes the Harness CRD validation so that
claudeandcodexharnesses rejectworkload.commandandworkload.args. The existing Agent harness page said that every harness honors an explicitworkload.command, and the Bring your own agent page said thatworkload.commandis optional for every non-BYO harness. Those statements contradicted the new API behavior.How to verify this change
claudeHarness that setsspec.workload.command.Claude harnesses do not support workload.command or workload.args.kagentHarness that setsspec.workload.commandandspec.workload.args.spec.workload.command: [].spec.workload.command in body should have at least 1 items.Proposed release note
Harness admission now rejects
workload.commandandworkload.argson Claude and Codex harnesses, and rejects an emptycommandorargslist on any harness.Files in this pull request
docs-site/content/kagent/main/agents/agent-harness.mddocs-site/content/kagent/main/agents/bring-your-own-agent.mdHow the pages were chosen (triage report)
Draft a documentation change
kagent-dev/kagent#3616 — fix(api): reject unsupported Harness workload overrides
kagent-dev/websiteworkload.commandandworkload.argson Claude and Codex harnesses, and rejects an emptycommandorargslist on any harness.Draft branch:
pr-tracker-draft-kagent-3616Important
The test suite has not run on this pull request. It was opened by
github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. This repository's checks are held asaction_requireduntil somebody presses Approve and run on the Checks tab. Checks that come from GitHub Apps rather than Actions, such as DCO, run on their own.Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.