Repository navigation
[Automated] Draft docs (kagent): feat(session): add opt-in crash recovery on send - #730
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…very on send Signed-off-by: GitHub Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target's own content scan fails where the base build passed (docs-theme-extras
markdown-leaks/built-html-integrity):kagent-dev/kagent#3399 — feat(session): add opt-in crash recovery on send
Docs versions:
mainNo code-path rule covers 10 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
go/api/gen/kagent/api/v1/sessions.pb.gogo/api/gen/kagent/config/v1/config.pb.gogo/core/internal/service/session/interactions.gogo/core/internal/service/session/recovery.gogo/core/internal/service/session/workflow.gogo/core/pkg/app/app.goWhat changes for users: Operators can set
config.sessions.automaticRecovery: trueso A2A sends attempt crash recovery without a separateRevertSessioncall. The default staysfalse; callers still need Session update access, and an in-progress recovery returnsKAGENT_SEND_NOT_ACCEPTEDwithstate: RECOVERING.What the docs now say: The Operational considerations page now documents
config.sessions.automaticRecovery, the default explicit-recovery behavior, the UI Recover action, and theRuntimeLostend state for runtimes that cannot be recovered.How
kagent-3399was draftedPlan, and what changed it
RevertSessionand crashed agent recovery.docs-site/content/kagent/main/operations/operational-considerations.mdwith the new setting and corrected the stale recovery behavior.Why a documentation change is necessary
The pull request adds
config.sessions.automaticRecovery, an opt-in controller setting that lets sends start or continue crashed runtime recovery. The operations page already explains node loss, crashed Actors, and explicitRevertSession, but it said kagent does not recover on its own and that the UI cannot recover a Session. Those claims became incomplete or stale after the change.How to verify this change
true.kagent config validate --component controller --config controller.yaml.config.sessions.automaticRecovery: true, the retry either reaches the recovered runtime or returnsKAGENT_SEND_NOT_ACCEPTEDwithstate: RECOVERINGandretryAfterMs: 1000.Proposed release note
No
proposed-release-note.md:markers.notes_placeableis false.Suggested note: kagent can now recover crashed runtimes during A2A sends when
config.sessions.automaticRecoveryis enabled. The setting defaults tofalse, and explicitRevertSessionrecovery remains available.Files in this pull request
docs-site/content/kagent/main/operations/operational-considerations.mdHow the pages were chosen (triage report)
Draft a documentation change
kagent-dev/kagent#3399 — feat(session): add opt-in crash recovery on send
kagent-dev/websitego/api/gen/kagent/api/v1/sessions.pb.gogo/api/gen/kagent/config/v1/config.pb.gogo/core/internal/service/session/interactions.gogo/core/internal/service/session/recovery.gogo/core/internal/service/session/workflow.gogo/core/pkg/app/app.goDraft branch:
pr-tracker-draft-kagent-3399Important
The test suite has not run on this pull request. It was opened by
github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. This repository's checks are held asaction_requireduntil somebody presses Approve and run on the Checks tab. Checks that come from GitHub Apps rather than Actions, such as DCO, run on their own.Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.