test: raise pkg coverage above 80% and bump tool versions#65
Merged
Conversation
Add unit tests across pkg providers so every package in ./pkg exceeds 80% statement coverage: - utils: 6.5% -> 100% (shell tool, kubeconfig, RegisterTools) - cilium: 46.7% -> 85.5% (cilium-dbg and CLI handlers) - argo: 49.7% -> 88.3% (gateway plugin, list/check logs, RegisterTools) - istio: 61.6% -> 92.7% (waypoint apply/delete/status, ztunnel) - prometheus: 72.4% -> 81.6% (RegisterTools, validation/error paths) - k8s: 73.9% -> 82.2% (RegisterTools, NewK8sToolWithConfig) Extract the shell tool closure into a named handleShellTool for testability. Bump tool versions to latest releases (make check-releases): - cilium 0.19.2 -> 0.19.4 - istio 1.29.1 -> 1.30.1 - helm 4.1.3 -> 4.2.2 - kubectl 1.35.3 -> 1.36.2 Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>
peterj
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./pkgexceeds 80% statement coverage.make check-releases).Coverage improvements
utilsciliumargoistioprometheusk8skubescapehelmNew tests target previously-uncovered handlers (cilium-dbg/CLI handlers, argo gateway plugin & list/logs, istio waypoint apply/delete/status + ztunnel, prometheus
RegisterTools/validation/error paths, k8sRegisterTools/NewK8sToolWithConfig, and the utils shell tool). Tests follow the existing conventions (mockedShellExecutor, table-driven subtests). The shell tool closure was extracted into a namedhandleShellToolfor testability (no behavior change).Tool version bumps (
make check-releases)0.19.2→0.19.41.29.1→1.30.14.1.3→4.2.21.35.3→1.36.2(
go.modalready at latest Go1.26.4.)Test plan
go test -tags=test ./pkg/...— all packages passgo test -tags=test -cover ./pkg/...— all packages > 80%make check-releases— all versions currentgo vet -tags=test ./pkg/...— clean