Skip to content

charts: stop OTLP push when no endpoint is set - #166

Merged
shashankram merged 1 commit into
kagent-dev:mainfrom
pennycoders:chart-otel-no-endpoint
Nov 13, 2026
Merged

shashankram merged 1 commit into
kagent-dev:mainfrom
pennycoders:chart-otel-no-endpoint

Conversation

@pennycoders

Copy link
Copy Markdown

With the default values (no otel.endpoint), ate-api-server, atelet, ate-controller and k8s-credential-provider push traces and metrics to the SDK default, localhost:4317, and log a connection error about once a minute.

  • A signal that is enabled but resolves no endpoint now renders OTEL_<SIGNAL>_EXPORTER like a disabled one. Metrics get prometheus rather than none: it stops the push but keeps every scraped endpoint, while none would also close atecontroller's :8080.
  • k8s-credential-provider includes substrate.otel.env like the other components. It had no env, so no value could configure or stop its export.
  • The same helper change goes into the copy in substrate-atelet.
  • README and values.yaml no longer say the Go components ignore otel.traces.enabled; serverboot honors OTEL_TRACES_EXPORTER.

With otel.endpoint set, the rendered env of the existing components is unchanged; only the credential provider gains its env.

Tested: helm lint on the four charts, hack/render-manifests.sh --check, helm unittest charts/substrate (three new cases, which fail without the template change), hack/verify-all.sh, and go test for the packages that render the chart.

Fixes #76

AI use: AI-assisted, I reviewed and tested it.

  • Tests pass
  • Docs updated

Fixes kagent-dev#76

Signed-off-by: Alex P <dtk077@gmail.com>
{{- $cfg := index $otel $signal }}
{{- if not $cfg.enabled }}
{{- /* Request no OTLP export with the SDK exporter name "none".
{{- if not (include "substrate.otel.signalEndpoint" (list $signal $)) }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove the “Empty when nothing under .Values.otel is set” sentence, since defaults now produce exporter environment variables.

@shashankram
shashankram merged commit accaa50 into kagent-dev:main Nov 13, 2026
6 checks passed
@pennycoders
pennycoders deleted the chart-otel-no-endpoint branch November 13, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Chart leaves OTLP export on when no endpoint is set, so components push to localhost:4317

2 participants