Skip to content

fix: extract content from function responses in session memory #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashrajshuklaaa wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −2
Open

fix: extract content from function responses in session memory #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions go/adk/pkg/memory/kagent_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,11 @@ func (s *KagentMemoryService) extractSessionContent(session adksession.Session)
// Get text content
text := part.Text
if text == "" && part.FunctionResponse != nil {
// TODO: Extract content from function response if needed
continue
responseJSON, err := json.Marshal(part.FunctionResponse.Response)
if err != nil || len(responseJSON) == 0 {
continue
}
text = fmt.Sprintf("[tool result from %s]: %s", part.FunctionResponse.Name, responseJSON)
}

if text != "" {
Expand Down
18 changes: 18 additions & 0 deletions go/adk/pkg/memory/kagent_service_grpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,13 @@ func TestKagentMemoryServiceExtractSessionContent(t *testing.T) {
name: "function call only",
events: []*adksession.Event{newMockEventWithFunctionCall("agent", "get_weather")},
},
{
name: "function response is extracted",
events: []*adksession.Event{
newMockEventWithFunctionResponse("agent", "get_weather", map[string]any{"temperature": 72, "condition": "sunny"}),
},
wantContent: `"condition":"sunny"`,
},
}

for _, test := range tests {
Expand Down Expand Up @@ -378,3 +385,14 @@ func newMockEventWithFunctionCall(author, functionName string) *adksession.Event
event.Content = &genai.Content{Role: author, Parts: []*genai.Part{{FunctionCall: &genai.FunctionCall{Name: functionName}}}}
return event
}

func newMockEventWithFunctionResponse(author, functionName string, response map[string]any) *adksession.Event {
event := newMockEvent(author, "")
event.Content = &genai.Content{
Role: author,
Parts: []*genai.Part{{
FunctionResponse: &genai.FunctionResponse{Name: functionName, Response: response},
}},
}
return event
}
Loading