Skip to content

Conversation

@yeikel
Copy link
Collaborator

@yeikel yeikel commented Sep 19, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

Updated the build and CI workflows to migrate from Java 21 to Java 25

What changes did you make? (Give an overview)

Closes #1349

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Docs pull request: kafbat/ui-docs#71

A picture of a cute animal (not mandatory but encouraged)

1f94f987f82b45049a035e9de95e3379

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 19, 2025
@yeikel yeikel marked this pull request as ready for review September 23, 2025 19:40
@yeikel yeikel requested review from a team as code owners September 23, 2025 19:40
@yeikel yeikel marked this pull request as draft September 23, 2025 19:40
@yeikel yeikel force-pushed the java-25 branch 3 times, most recently from bd916e2 to 80a3369 Compare November 16, 2025 21:14
@yeikel yeikel force-pushed the java-25 branch 6 times, most recently from 86fa89a to 1409d8c Compare November 18, 2025 01:41
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # infered from @v4
with:
java-version: '21'
java-version-file: '.java-version'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are using .java-version to track the version, I think that it makes sense to leverage this feature from actions/setup-java to make it easier to upgrade in the future

assertj = '3.25.3'
avro = '1.11.4'
byte-buddy = '1.14.19'
byte-buddy = '1.18.1'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first version of byte-buddy that supports Java 25 is 1.17.5

@yeikel
Copy link
Collaborator Author

yeikel commented Nov 18, 2025

@germanosin @Haarolean This pull request is ready for review

The build failure below occurs because these workflows run under pull_request_target, which means the workflow definitions from main are being used instead of my updated version that uses Java 25

However, I merged these workflow changes into the main branch of my fork, and you can see the successful build there: yeikel#269

[Incubating] Problems report is available at: file:///home/runner/work/kafka-ui/kafka-ui/build/reports/problems/problems-report.html
FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':contract:compileJava'.

Java compilation initialization error
error: invalid source release: 25

@yeikel yeikel marked this pull request as ready for review November 18, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BE: Upgrade to Java 25

1 participant