-
-
Notifications
You must be signed in to change notification settings - Fork 212
BE: Migrate to Java 25 #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
BE: Migrate to Java 25 #1355
Conversation
bd916e2 to
80a3369
Compare
86fa89a to
1409d8c
Compare
| uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # infered from @v4 | ||
| with: | ||
| java-version: '21' | ||
| java-version-file: '.java-version' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we are using .java-version to track the version, I think that it makes sense to leverage this feature from actions/setup-java to make it easier to upgrade in the future
| assertj = '3.25.3' | ||
| avro = '1.11.4' | ||
| byte-buddy = '1.14.19' | ||
| byte-buddy = '1.18.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first version of byte-buddy that supports Java 25 is 1.17.5
|
@germanosin @Haarolean This pull request is ready for review The build failure below occurs because these workflows run under However, I merged these workflow changes into the
|
Updated the build and CI workflows to migrate from Java 21 to Java 25
What changes did you make? (Give an overview)
Closes #1349
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Docs pull request: kafbat/ui-docs#71
A picture of a cute animal (not mandatory but encouraged)