Skip to content

skaffold(cloud): add additive cockpit profile (upstream convention)#76

Draft
ConstanzeTU wants to merge 1 commit into
mainfrom
skaffold-cockpit-profile
Draft

skaffold(cloud): add additive cockpit profile (upstream convention)#76
ConstanzeTU wants to merge 1 commit into
mainfrom
skaffold-cockpit-profile

Conversation

@ConstanzeTU

Copy link
Copy Markdown

What

Adds a cockpit profile to skaffold/skaffold_cloud.yaml additively, following upstream skaffold conventions.

- name: cockpit
  patches:
  - op: replace
    path: /manifests/kustomize/paths
    value:
    - private/cockpit

Why this shape

The fork's current cockpit deploy (on the PR-68 branch) replaces all eight upstream profiles (minikube/dev/ory_auth/ory_auth_prod/staging/testing/prod/public) with a single cockpit profile and drops --action_env=GOOGLE_APPLICATION_CREDENTIALS. That diverges hard from upstream and makes the file painful to reconcile.

This PR instead keeps every upstream profile and .common_bazel_args untouched and appends cockpit as one more profile, mirroring the public pattern — a minimal, upstream-friendly diff (+10 lines).

Dependencies & the deployment-pipeline change

Draft

Marked draft because it's coupled to the external deployment-pipeline change above and the -p cockpit wiring. The profile shape (additive, path private/cockpit, keeping GOOGLE_APPLICATION_CREDENTIALS) is a proposal — easy to adjust.

Reworks the fork's cockpit deploy to fit upstream skaffold conventions:
instead of replacing all upstream profiles with a single cockpit profile
(the shape currently on the PR-68 branch), this keeps every upstream
profile (minikube/dev/ory_auth/staging/testing/prod/public) intact and
adds `cockpit` as one more profile, mirroring the `public` pattern.

Deploy the fork cloud with `skaffold run -f skaffold/skaffold_cloud.yaml
-p cockpit`. The kustomize target private/cockpit/ is restored by PR #72.

skaffold/** is already frozen in copybara ignored_dirs, so this survives
the OSS mirror. NOTE: the deployment pipeline that runs the cloud deploy
must pass `-p cockpit` — that change is external to this repo (no CI
workflow invokes skaffold_cloud.yaml; only DEVELOPMENT.md references it).
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7c1c7a13-7bd5-4ee9-9656-05b9fe4ce9a3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skaffold-cockpit-profile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants