Keystone: RoleAssignment Controller#774
Open
dlaw4608 wants to merge 2 commits into
Open
Conversation
…t Controller Signed-off-by: Daniel Lawton <dlawton@redhat.com>
dlaw4608
force-pushed
the
role_assignment
branch
3 times, most recently
from
a79310e to
1235e66
Compare
…ationships
rather than resources, since OpenStack doesn't assign IDs to role assignments.
Key changes:
- Custom reconciler: Ignores generic framework since role assignments lack
OpenStack resource IDs
- Component-based identification: Uses tuple (roleID, userID/groupID,
projectID/domainID) stored in Status.Resource instead of UIDs
- Status.ID intentionally nil: Components serve as natural identifiers
- Immutable spec: Role assignments can't be modified after creation
(matching Kubernetes RBAC behavior)
- Deletion guards: All dependencies (Role, User/Group, Project/Domain)
protected from deletion while in use
E2E tests cover four actor-scope combinations:
- roleassignment-create-user-project
- roleassignment-create-user-domain
- roleassignment-create-group-project
- roleassignment-create-group-domain
Plus roleassignment-dependency test verifying deletion guard behavior.
Implementation details:
- reconciler.go: Custom reconcile loop handling create/delete lifecycle
- actuator.go: GetResourceByComponents() replaces GetOSResourceByID()
Signed-off-by: Daniel Lawton <dlawton@redhat.com>
|
@mandre Can you have a look please? We need this one soonish. |
Collaborator
Will do. We can review this new controller and merge it soon, but I can't promise this will be in a release shortly (we've switched the main branch to v3 development and I'm a bit reluctant about backporting controllers to v2 as). We'll see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #669
Implement RoleAssignment controller treating role assignments as relationships
rather than resources, since OpenStack doesn't assign IDs to role assignments.
Key changes:
- Custom reconciler: Ignores generic framework since role assignments lack
OpenStack resource IDs
- Component-based identification: Uses tuple (roleID, userID/groupID,
projectID/domainID) stored in Status.Resource instead of UIDs
- Status.ID intentionally nil: Components serve as natural identifiers
- Immutable spec: Role assignments can't be modified after creation
(matching Kubernetes RBAC behavior)
- Deletion guards: All dependencies (Role, User/Group, Project/Domain)
protected from deletion while in use
E2E tests cover four actor-scope combinations:
- roleassignment-create-user-project
- roleassignment-create-user-domain
- roleassignment-create-group-project
- roleassignment-create-group-domain
Plus roleassignment-dependency test verifying deletion guard behavior.
Implementation details:
- reconciler.go: Custom reconcile loop handling create/delete lifecycle
- actuator.go: GetResourceByComponents() replaces GetOSResourceByID()
API Ref: https://docs.openstack.org/api-ref/identity/v3/index.html#roles