-
Notifications
You must be signed in to change notification settings - Fork 33
Keystone: Endpoint controller #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /* | ||
| Copyright 2025 The ORC Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| // EndpointResourceSpec contains the desired state of the resource. | ||
| type EndpointResourceSpec struct { | ||
| // name will be the name of the created resource. If not specified, the | ||
| // name of the ORC object will be used. | ||
| // +optional | ||
| Name *OpenStackName `json:"name,omitempty"` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer we do not merge this until we have removed the requirement for Name in gophercloud because this will be a breaking change in the ORC API. This is another argument for waiting for the next gophecloud release where you've had several improvements to the support of endpoint. |
||
|
|
||
| // enabled indicates whether the endpoint is enabled or not. | ||
| // +kubebuilder:default:=true | ||
| // +optional | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It feels like the Alternatively, we wait a bit for the next gophercloud release so that we have a clean PR from the start (we can include gophercloud/gophercloud#3581 in it too). |
||
|
|
||
| // interface indicates the visibility of the endpoint. | ||
| // +kubebuilder:validation:Enum:=admin;internal;public | ||
| // +required | ||
| Interface string `json:"interface,omitempty"` | ||
|
|
||
| // url is the endpoint URL. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +required | ||
| URL string `json:"url"` | ||
|
|
||
| // serviceRef is a reference to the ORC Service which this resource is associated with. | ||
| // +required | ||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="serviceRef is immutable" | ||
| ServiceRef KubernetesNameRef `json:"serviceRef,omitempty"` | ||
| } | ||
|
|
||
| // EndpointFilter defines an existing resource by its properties | ||
| // +kubebuilder:validation:MinProperties:=1 | ||
| type EndpointFilter struct { | ||
| // interface of the existing endpoint. | ||
| // +kubebuilder:validation:Enum:=admin;internal;public | ||
| // +optional | ||
| Interface string `json:"interface,omitempty"` | ||
|
|
||
| // serviceRef is a reference to the ORC Service which this resource is associated with. | ||
| // +optional | ||
| ServiceRef *KubernetesNameRef `json:"serviceRef,omitempty"` | ||
|
|
||
| // url is the URL of the existing endpoint. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| URL string `json:"url,omitempty"` | ||
| } | ||
|
|
||
| // EndpointResourceStatus represents the observed state of the resource. | ||
| type EndpointResourceStatus struct { | ||
| // name is a Human-readable name for the resource. Might not be unique. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| Name string `json:"name,omitempty"` | ||
|
|
||
| // enabled indicates whether the endpoint is enabled or not. | ||
| // +optional | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can drop the pointer in the status. |
||
|
|
||
| // interface indicates the visibility of the endpoint. | ||
| // +kubebuilder:validation:Enum:=admin;internal;public | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we want to drop the enum validation in the status and instead return whatever OpenStack gives us. We still want to have a MaxLength validation. |
||
| // +optional | ||
| Interface string `json:"interface,omitempty"` | ||
|
|
||
| // url is the endpoint URL. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| URL string `json:"url,omitempty"` | ||
|
|
||
| // serviceID is the ID of the Service to which the resource is associated. | ||
| // +kubebuilder:validation:MaxLength=1024 | ||
| // +optional | ||
| ServiceID string `json:"serviceID,omitempty"` | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can make it a ✔ when we're based on a newer gophercloud.