Add role field to User model with updated baseline and docs#5
Merged
Conversation
- Added 'role' field (default: 'member') to User and UserCreate models - Regenerated OpenAPI baseline and api_reference.md via drift_guard baseline - Docs now reflect the role field in request/response schemas and example curls Co-Authored-By: unknown <>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add role field to User model with updated baseline and docs
Summary
Adds an optional
rolefield (default:"member") to bothUserCreateandUserPydantic models. Thecreate_userendpoint now passes the role through. The OpenAPI baseline and auto-generatedapi_reference.mdhave been regenerated to reflect the schema change.This is a backward-compatible change — existing clients that don't send
rolewill get the default value.Review & Testing Checklist for Human
_users_db(Alice, Bob) don't explicitly setrole. Verify thatGET /v1/users/1returns"role": "member"via the Pydantic default — runcurl localhost:8000/v1/users/1with the server up.tests/test_contract.pydoesn't assert on therolefield. Decide whether tests should be added to validateroleappears in responses and is accepted in POST requests.artifacts/openapi_baseline.jsonwas previously absent. Skim it to confirm it looks reasonable and matches the running API (curl localhost:8000/openapi.json).Notes
docs/api_reference.mdwent from a placeholder stub to a fully generated doc — the large diff is expected and auto-generatedrolehas a default so no existing client calls will breakLink to Devin run: https://app.devin.ai/sessions/23d1e596e5f845ec8c47886363e9b2b8
Requested by: @justinemach