Skip to content

Ensure overriding minor mode is enabled in the correct buffer #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure overriding minor mode is enabled in the correct buffer #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions bind-map.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,16 +407,18 @@ mode maps. Set up by bind-map.el." map))
(add-hook ',(intern (format "%s-hook" override-mode))
#'evil-normalize-keymaps))
;; Defensive hook to ensure the mode is enabled in buffers that may
;; have been created in unusual ways (e.g., programmatically via
;; get-buffer-create). This catches cases where after-change-major-mode-hook
;; might not fire or fires before the global mode is enabled.
(defun ,ensure-override-mode-func ()
;; have been created in unusual ways (e.g., without ever calling a
;; major mode function). This catches cases where
;; `after-change-major-mode-hook' might not fire or fires before the
;; global mode is enabled.
(defun ,ensure-override-mode-func (frame)
,ensure-override-mode-doc
(when (and ,global-override-mode
(not ,override-mode)
(not (minibufferp)))
(,override-mode 1)))
(add-hook 'buffer-list-update-hook #',ensure-override-mode-func)))
(with-current-buffer (window-buffer (frame-selected-window frame))
(when (and ,global-override-mode
(not ,override-mode)
(not (minibufferp)))
(,override-mode 1))))
(add-hook 'window-state-change-functions #',ensure-override-mode-func)))

(if (or minor-modes major-modes)
;; only bind keys in root-map
Expand Down