Skip to content

⚡ Bolt: [performance improvement] avoid intermediate String allocations for track duration formatting - #143

Open
juntaochi wants to merge 1 commit into
mainfrom
bolt-duration-allocation-opt-2197866325734240190
Open

⚡ Bolt: [performance improvement] avoid intermediate String allocations for track duration formatting#143
juntaochi wants to merge 1 commit into
mainfrom
bolt-duration-allocation-opt-2197866325734240190

Conversation

@juntaochi

Copy link
Copy Markdown
Owner

💡 What:
Replaced the format_duration and format_duration_seconds helper functions with newtype wrappers (DisplayDuration and DisplayDurationSeconds) that implement std::fmt::Display.

🎯 Why:
The original functions allocated a String (e.g., "03:45" or "225s") which was then immediately passed into another format! macro during the UI loop. This caused unnecessary intermediate heap allocations on every render tick for the progress bar and metadata sections.

📊 Impact:
Eliminates 8 redundant String heap allocations per tick in src/ui/mod.rs (draw_progress and metadata caching). By utilizing std::fmt::Display, formatting is written directly to the outer buffer, providing a zero-cost abstraction without sacrificing readability.

🔬 Measurement:
Run cargo clippy -- -D warnings and cargo test to verify behavior remains completely identical while avoiding allocations. Benchmark of the Display pattern via independent rustc test verifies identical output format.


PR created automatically by Jules for task 2197866325734240190 started by @juntaochi

Replaced `format_duration` and `format_duration_seconds` functions (which allocated intermediate Strings) with `DisplayDuration` and `DisplayDurationSeconds` wrapper structs that implement `std::fmt::Display`. This avoids intermediate heap allocations during the high-frequency UI rendering loop.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant