Skip to content

⚡ Bolt: Inline duration string formatting to reduce heap allocations - #139

Open
juntaochi wants to merge 1 commit into
mainfrom
bolt/inline-duration-formats-10817319766327714170
Open

⚡ Bolt: Inline duration string formatting to reduce heap allocations#139
juntaochi wants to merge 1 commit into
mainfrom
bolt/inline-duration-formats-10817319766327714170

Conversation

@juntaochi

Copy link
Copy Markdown
Owner

💡 What:
Inlined duration formatting logic directly into format! macros in src/ui/mod.rs and removed the helper functions format_duration and format_duration_seconds which allocated intermediate strings.

🎯 Why:
The TUI draw loop runs frequently (~500ms intervals). Nested format! macro calls like format!("{} / {}", format_duration(...), format_duration(...)) generate multiple intermediate String objects allocated on the heap, which causes unnecessary overhead and GC/allocator pressure in a hot path.

📊 Impact:
Reduces String heap allocations by two per UI label during rendering loops.

🔬 Measurement:
A standalone benchmark script demonstrates the inlined formatting output exactly matches the previous logic, while completely avoiding intermediate string allocations. Passed all unit tests via cargo test.


PR created automatically by Jules for task 10817319766327714170 started by @juntaochi

Reduces intermediate String allocations in the TUI render loop.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant