⚡ Bolt: Inline duration string formatting to reduce heap allocations - #139
⚡ Bolt: Inline duration string formatting to reduce heap allocations#139juntaochi wants to merge 1 commit into
Conversation
Reduces intermediate String allocations in the TUI render loop.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Inlined duration formatting logic directly into
format!macros insrc/ui/mod.rsand removed the helper functionsformat_durationandformat_duration_secondswhich allocated intermediate strings.🎯 Why:
The TUI
drawloop runs frequently (~500ms intervals). Nestedformat!macro calls likeformat!("{} / {}", format_duration(...), format_duration(...))generate multiple intermediateStringobjects allocated on the heap, which causes unnecessary overhead and GC/allocator pressure in a hot path.📊 Impact:
Reduces
Stringheap allocations by two per UI label during rendering loops.🔬 Measurement:
A standalone benchmark script demonstrates the inlined formatting output exactly matches the previous logic, while completely avoiding intermediate string allocations. Passed all unit tests via
cargo test.PR created automatically by Jules for task 10817319766327714170 started by @juntaochi