⚡ Bolt: Use MetadataCache for rendering track metadata and progress - #138
⚡ Bolt: Use MetadataCache for rendering track metadata and progress#138juntaochi wants to merge 2 commits into
Conversation
- Replaced `&Track` with `&MetadataCache` in `draw_metadata` and `draw_progress`. - Passes values as `&str` references directly from the cache to avoid dynamically calculating duration percentages and running `.to_uppercase()` strings. - Removed formatting dynamic string allocations inside the TUI render loop.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replaced `&Track` with `&MetadataCache` in `draw_metadata` and `draw_progress`. - Passes values as `&str` references directly from the cache to avoid dynamically calculating duration percentages. - Removed formatting dynamic string allocations inside the TUI render loop.
1 participant
💡 What:
Replaced
track: &Trackarguments withcache: &MetadataCachein bothdraw_metadataanddraw_progressrendering functions insidesrc/ui/mod.rs. Track strings are now pulled as&strreferences (cache.name.as_str()) instead of being rebuilt and formatted (track.name.to_uppercase()) every frame.🎯 Why:
The Ratatui
drawloop runs frequently (every ~500ms). Constructing strings usingformat!(), calculating numeric percentages, and manipulating strings (.to_uppercase()) on every frame creates unnecessary CPU overhead and continuous short-lived heap allocations (String). The application already computes and stores these values correctly in theMetadataCacheduring theApp::updatetick, so the render loop just wasn't utilizing them.📊 Impact:
🔬 Measurement:
cargo test,cargo fmt, andcargo clippy.PR created automatically by Jules for task 8837283909131043717 started by @juntaochi