chore: upgrade to Python 3.14#775
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRepository baseline is updated to Python 3.12: local pin, CI pytest matrix (3.12–3.14), Ruff target, example projects, and package manifests across core packages and all driver packages adjust ChangesPython 3.12 baseline rollout
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
python/packages/jumpstarter-driver-iscsi/pyproject.toml (1)
1-8:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd required Apache-2.0 license metadata to this package.
[project]is missinglicense = "Apache-2.0", which violates the repository packaging policy.Suggested fix
[project] name = "jumpstarter-driver-iscsi" dynamic = ["version", "urls"] description = "Exporter ISCSI service driver" readme = "README.md" +license = "Apache-2.0" authors = [{ name = "Benny Zlotnik", email = "bzlotnik@redhat.com" }] requires-python = ">=3.14"As per coding guidelines, “All packages must use Apache-2.0 license as specified in pyproject.toml”.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@python/packages/jumpstarter-driver-iscsi/pyproject.toml` around lines 1 - 8, Add the required Apache-2.0 license metadata to the pyproject.toml [project] metadata: update the project table in "pyproject.toml" (the [project] block for the package jumpstarter-driver-iscsi) to include license = "Apache-2.0" so the package metadata complies with repository packaging policy; place the new license field alongside existing keys like name, dynamic, description, readme, authors, and requires-python.Source: Coding guidelines
python/packages/jumpstarter-driver-http/pyproject.toml (1)
41-42:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove duplicate
pytest-asyncioconstraints in dev dependencies.Having both
pytest-asyncio>=0.0.0andpytest-asyncio>=0.24.0is redundant and can confuse dependency resolution intent; keep only the stricter constraint.Suggested cleanup
[dependency-groups] dev = [ "pytest-cov>=6.0.0", "pytest>=8.3.3", - "pytest-asyncio>=0.0.0", "pytest-asyncio>=0.24.0", ]🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@python/packages/jumpstarter-driver-http/pyproject.toml` around lines 41 - 42, Remove the duplicate pytest-asyncio entries from the dev dependencies in pyproject.toml by deleting the weaker constraint "pytest-asyncio>=0.0.0" and keeping the stricter "pytest-asyncio>=0.24.0" (ensure the duplicate string entries under the dev-dependencies section are consolidated so only the >=0.24.0 constraint remains).python/packages/jumpstarter-driver-opendal/pyproject.toml (1)
18-20:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRegister this package under
jumpstarter.drivers(or rename/scope it if it is adapter-only).For a
jumpstarter-driver-*package, the requiredproject.entry-points."jumpstarter.drivers"registration is missing.As per coding guidelines, “Drivers must register via
jumpstarter.driversentry point in pyproject.toml”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@python/packages/jumpstarter-driver-opendal/pyproject.toml` around lines 18 - 20, The pyproject.toml registers the package under project.entry-points."jumpstarter.adapters" but for a jumpstarter-driver-* package it must register under project.entry-points."jumpstarter.drivers"; update the entry-point group to "jumpstarter.drivers" (or if this package is strictly an adapter, rename/scope the package accordingly) and ensure the entry maps the OpendalAdapter symbol (jumpstarter_driver_opendal.adapters:OpendalAdapter) under that group so the driver is discoverable.Sources: Coding guidelines, Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@python/packages/jumpstarter-driver-http/pyproject.toml`:
- Around line 41-42: Remove the duplicate pytest-asyncio entries from the dev
dependencies in pyproject.toml by deleting the weaker constraint
"pytest-asyncio>=0.0.0" and keeping the stricter "pytest-asyncio>=0.24.0"
(ensure the duplicate string entries under the dev-dependencies section are
consolidated so only the >=0.24.0 constraint remains).
In `@python/packages/jumpstarter-driver-iscsi/pyproject.toml`:
- Around line 1-8: Add the required Apache-2.0 license metadata to the
pyproject.toml [project] metadata: update the project table in "pyproject.toml"
(the [project] block for the package jumpstarter-driver-iscsi) to include
license = "Apache-2.0" so the package metadata complies with repository
packaging policy; place the new license field alongside existing keys like name,
dynamic, description, readme, authors, and requires-python.
In `@python/packages/jumpstarter-driver-opendal/pyproject.toml`:
- Around line 18-20: The pyproject.toml registers the package under
project.entry-points."jumpstarter.adapters" but for a jumpstarter-driver-*
package it must register under project.entry-points."jumpstarter.drivers";
update the entry-point group to "jumpstarter.drivers" (or if this package is
strictly an adapter, rename/scope the package accordingly) and ensure the entry
maps the OpendalAdapter symbol
(jumpstarter_driver_opendal.adapters:OpendalAdapter) under that group so the
driver is discoverable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f69689ae-69d2-4fbc-8ba7-999be9c428c7
⛔ Files ignored due to path filters (1)
python/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (65)
.github/workflows/python-tests.yaml.py-versionpython/examples/android-emulator/pyproject.tomlpython/examples/automotive/pyproject.tomlpython/examples/soc-pytest/pyproject.tomlpython/examples/xcp-ecu/pyproject.tomlpython/packages/hatch-pin-jumpstarter/pyproject.tomlpython/packages/jumpstarter-all/pyproject.tomlpython/packages/jumpstarter-cli-admin/pyproject.tomlpython/packages/jumpstarter-cli-common/pyproject.tomlpython/packages/jumpstarter-cli-driver/pyproject.tomlpython/packages/jumpstarter-cli/pyproject.tomlpython/packages/jumpstarter-driver-adb/pyproject.tomlpython/packages/jumpstarter-driver-androidemulator/pyproject.tomlpython/packages/jumpstarter-driver-ble/pyproject.tomlpython/packages/jumpstarter-driver-can/pyproject.tomlpython/packages/jumpstarter-driver-composite/pyproject.tomlpython/packages/jumpstarter-driver-corellium/pyproject.tomlpython/packages/jumpstarter-driver-doip/pyproject.tomlpython/packages/jumpstarter-driver-dut-network/pyproject.tomlpython/packages/jumpstarter-driver-dutlink/pyproject.tomlpython/packages/jumpstarter-driver-energenie/pyproject.tomlpython/packages/jumpstarter-driver-esp32/pyproject.tomlpython/packages/jumpstarter-driver-flashers/pyproject.tomlpython/packages/jumpstarter-driver-gpiod/pyproject.tomlpython/packages/jumpstarter-driver-http-power/pyproject.tomlpython/packages/jumpstarter-driver-http/pyproject.tomlpython/packages/jumpstarter-driver-iscsi/pyproject.tomlpython/packages/jumpstarter-driver-mitmproxy/pyproject.tomlpython/packages/jumpstarter-driver-network/pyproject.tomlpython/packages/jumpstarter-driver-noyito-relay/pyproject.tomlpython/packages/jumpstarter-driver-opendal/pyproject.tomlpython/packages/jumpstarter-driver-pi-pico/pyproject.tomlpython/packages/jumpstarter-driver-power/pyproject.tomlpython/packages/jumpstarter-driver-probe-rs/pyproject.tomlpython/packages/jumpstarter-driver-pyserial/pyproject.tomlpython/packages/jumpstarter-driver-qemu/pyproject.tomlpython/packages/jumpstarter-driver-renode/pyproject.tomlpython/packages/jumpstarter-driver-ridesx/pyproject.tomlpython/packages/jumpstarter-driver-sdwire/pyproject.tomlpython/packages/jumpstarter-driver-shell/pyproject.tomlpython/packages/jumpstarter-driver-snmp/pyproject.tomlpython/packages/jumpstarter-driver-someip/pyproject.tomlpython/packages/jumpstarter-driver-ssh-mitm/pyproject.tomlpython/packages/jumpstarter-driver-ssh-mount/pyproject.tomlpython/packages/jumpstarter-driver-ssh/pyproject.tomlpython/packages/jumpstarter-driver-stlink-msd/pyproject.tomlpython/packages/jumpstarter-driver-tasmota/pyproject.tomlpython/packages/jumpstarter-driver-tftp/pyproject.tomlpython/packages/jumpstarter-driver-tmt/pyproject.tomlpython/packages/jumpstarter-driver-uboot/pyproject.tomlpython/packages/jumpstarter-driver-uds-can/pyproject.tomlpython/packages/jumpstarter-driver-uds-doip/pyproject.tomlpython/packages/jumpstarter-driver-uds/pyproject.tomlpython/packages/jumpstarter-driver-ustreamer/pyproject.tomlpython/packages/jumpstarter-driver-vnc/pyproject.tomlpython/packages/jumpstarter-driver-xcp/pyproject.tomlpython/packages/jumpstarter-driver-yepkit/pyproject.tomlpython/packages/jumpstarter-imagehash/pyproject.tomlpython/packages/jumpstarter-kubernetes/pyproject.tomlpython/packages/jumpstarter-mcp/pyproject.tomlpython/packages/jumpstarter-protocol/pyproject.tomlpython/packages/jumpstarter-testing/pyproject.tomlpython/packages/jumpstarter/pyproject.tomlpython/pyproject.toml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/packages/jumpstarter-driver-shell/pyproject.toml`:
- Line 7: Update the Python driver template's pyproject setting: locate the
requires-python entry in python/__templates__/driver/pyproject.toml.tmpl (used
by python/__templates__/create_driver.sh) and change requires-python = ">=3.11"
to requires-python = ">=3.12" so newly generated drivers match existing
packages; verify no other template copies still use ">=3.11".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1902221a-cbd7-4ae7-b4ed-a776da798944
📒 Files selected for processing (65)
.github/workflows/python-tests.yamlPR_DESCRIPTION.mdpython/examples/android-emulator/pyproject.tomlpython/examples/automotive/pyproject.tomlpython/examples/soc-pytest/pyproject.tomlpython/examples/xcp-ecu/pyproject.tomlpython/packages/hatch-pin-jumpstarter/pyproject.tomlpython/packages/jumpstarter-all/pyproject.tomlpython/packages/jumpstarter-cli-admin/pyproject.tomlpython/packages/jumpstarter-cli-common/pyproject.tomlpython/packages/jumpstarter-cli-driver/pyproject.tomlpython/packages/jumpstarter-cli/pyproject.tomlpython/packages/jumpstarter-driver-adb/pyproject.tomlpython/packages/jumpstarter-driver-androidemulator/pyproject.tomlpython/packages/jumpstarter-driver-ble/pyproject.tomlpython/packages/jumpstarter-driver-can/pyproject.tomlpython/packages/jumpstarter-driver-composite/pyproject.tomlpython/packages/jumpstarter-driver-corellium/pyproject.tomlpython/packages/jumpstarter-driver-doip/pyproject.tomlpython/packages/jumpstarter-driver-dut-network/pyproject.tomlpython/packages/jumpstarter-driver-dutlink/pyproject.tomlpython/packages/jumpstarter-driver-energenie/pyproject.tomlpython/packages/jumpstarter-driver-esp32/pyproject.tomlpython/packages/jumpstarter-driver-flashers/pyproject.tomlpython/packages/jumpstarter-driver-gpiod/pyproject.tomlpython/packages/jumpstarter-driver-http-power/pyproject.tomlpython/packages/jumpstarter-driver-http/pyproject.tomlpython/packages/jumpstarter-driver-iscsi/pyproject.tomlpython/packages/jumpstarter-driver-mitmproxy/pyproject.tomlpython/packages/jumpstarter-driver-network/pyproject.tomlpython/packages/jumpstarter-driver-noyito-relay/pyproject.tomlpython/packages/jumpstarter-driver-opendal/pyproject.tomlpython/packages/jumpstarter-driver-pi-pico/pyproject.tomlpython/packages/jumpstarter-driver-power/pyproject.tomlpython/packages/jumpstarter-driver-probe-rs/pyproject.tomlpython/packages/jumpstarter-driver-pyserial/pyproject.tomlpython/packages/jumpstarter-driver-qemu/pyproject.tomlpython/packages/jumpstarter-driver-renode/pyproject.tomlpython/packages/jumpstarter-driver-ridesx/pyproject.tomlpython/packages/jumpstarter-driver-sdwire/pyproject.tomlpython/packages/jumpstarter-driver-shell/pyproject.tomlpython/packages/jumpstarter-driver-snmp/pyproject.tomlpython/packages/jumpstarter-driver-someip/pyproject.tomlpython/packages/jumpstarter-driver-ssh-mitm/pyproject.tomlpython/packages/jumpstarter-driver-ssh-mount/pyproject.tomlpython/packages/jumpstarter-driver-ssh/pyproject.tomlpython/packages/jumpstarter-driver-stlink-msd/pyproject.tomlpython/packages/jumpstarter-driver-tasmota/pyproject.tomlpython/packages/jumpstarter-driver-tftp/pyproject.tomlpython/packages/jumpstarter-driver-tmt/pyproject.tomlpython/packages/jumpstarter-driver-uboot/pyproject.tomlpython/packages/jumpstarter-driver-uds-can/pyproject.tomlpython/packages/jumpstarter-driver-uds-doip/pyproject.tomlpython/packages/jumpstarter-driver-uds/pyproject.tomlpython/packages/jumpstarter-driver-ustreamer/pyproject.tomlpython/packages/jumpstarter-driver-vnc/pyproject.tomlpython/packages/jumpstarter-driver-xcp/pyproject.tomlpython/packages/jumpstarter-driver-yepkit/pyproject.tomlpython/packages/jumpstarter-imagehash/pyproject.tomlpython/packages/jumpstarter-kubernetes/pyproject.tomlpython/packages/jumpstarter-mcp/pyproject.tomlpython/packages/jumpstarter-protocol/pyproject.tomlpython/packages/jumpstarter-testing/pyproject.tomlpython/packages/jumpstarter/pyproject.tomlpython/pyproject.toml
✅ Files skipped from review due to trivial changes (11)
- PR_DESCRIPTION.md
- python/packages/jumpstarter-driver-someip/pyproject.toml
- python/examples/android-emulator/pyproject.toml
- python/packages/hatch-pin-jumpstarter/pyproject.toml
- python/packages/jumpstarter-protocol/pyproject.toml
- python/packages/jumpstarter-driver-androidemulator/pyproject.toml
- python/packages/jumpstarter-driver-xcp/pyproject.toml
- python/packages/jumpstarter-driver-esp32/pyproject.toml
- python/packages/jumpstarter-driver-ssh-mount/pyproject.toml
- python/packages/jumpstarter-driver-composite/pyproject.toml
- python/packages/jumpstarter-kubernetes/pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (22)
- python/packages/jumpstarter-driver-vnc/pyproject.toml
- python/packages/jumpstarter-driver-noyito-relay/pyproject.toml
- python/packages/jumpstarter-cli-admin/pyproject.toml
- python/packages/jumpstarter-cli-common/pyproject.toml
- python/packages/jumpstarter-driver-network/pyproject.toml
- python/packages/jumpstarter-driver-mitmproxy/pyproject.toml
- python/packages/jumpstarter-driver-ustreamer/pyproject.toml
- python/packages/jumpstarter-driver-corellium/pyproject.toml
- python/examples/automotive/pyproject.toml
- python/packages/jumpstarter/pyproject.toml
- python/packages/jumpstarter-driver-ridesx/pyproject.toml
- python/packages/jumpstarter-driver-flashers/pyproject.toml
- python/packages/jumpstarter-driver-ssh/pyproject.toml
- python/packages/jumpstarter-driver-uds-can/pyproject.toml
- python/packages/jumpstarter-driver-renode/pyproject.toml
- python/packages/jumpstarter-cli-driver/pyproject.toml
- python/packages/jumpstarter-driver-uds/pyproject.toml
- python/packages/jumpstarter-testing/pyproject.toml
- python/packages/jumpstarter-driver-doip/pyproject.toml
- python/packages/jumpstarter-driver-tasmota/pyproject.toml
- python/examples/soc-pytest/pyproject.toml
- python/packages/jumpstarter-driver-pyserial/pyproject.toml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/packages/jumpstarter-driver-opendal/pyproject.toml`:
- Line 18: Add the missing entry point group for the driver so the Opendal
driver is discoverable: in the pyproject.toml for the jumpstarter-driver-opendal
package, add a [project.entry-points."jumpstarter.drivers"] section that
registers the Opendal driver class (the concrete driver symbol used in this
package) alongside or in addition to the existing
[project.entry-points."jumpstarter.adapters"] registration; alternatively, if
the package intentionally does not expose a driver, add a short comment or
README note in the package explaining why no
[project.entry-points."jumpstarter.drivers"] entry exists so maintainers know
this is deliberate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f56550fc-29ec-425d-9816-eec8940497ea
📒 Files selected for processing (2)
python/__templates__/driver/pyproject.toml.tmplpython/packages/jumpstarter-driver-opendal/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
- python/templates/driver/pyproject.toml.tmpl
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/packages/jumpstarter-driver-opendal/pyproject.toml`:
- Line 18: Add the missing entry point group for the driver so the Opendal
driver is discoverable: in the pyproject.toml for the jumpstarter-driver-opendal
package, add a [project.entry-points."jumpstarter.drivers"] section that
registers the Opendal driver class (the concrete driver symbol used in this
package) alongside or in addition to the existing
[project.entry-points."jumpstarter.adapters"] registration; alternatively, if
the package intentionally does not expose a driver, add a short comment or
README note in the package explaining why no
[project.entry-points."jumpstarter.drivers"] entry exists so maintainers know
this is deliberate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f56550fc-29ec-425d-9816-eec8940497ea
📒 Files selected for processing (2)
python/__templates__/driver/pyproject.toml.tmplpython/packages/jumpstarter-driver-opendal/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
- python/templates/driver/pyproject.toml.tmpl
🛑 Comments failed to post (1)
python/packages/jumpstarter-driver-opendal/pyproject.toml (1)
18-18:
⚠️ Potential issue | 🟠 Major🧩 Analysis chain
🏁 Script executed:
#!/bin/bash # Description: Check entry point registration patterns across all driver packages # Find all driver package pyproject.toml files and show their entry points fd -t f 'pyproject.toml' 'python/packages/jumpstarter-driver-*' --exec sh -c ' echo "=== {} ===" rg -A2 "project.entry-points" {} || echo "No entry-points found" echo 'Repository: jumpstarter-dev/jumpstarter
Length of output: 195
Fix missing
jumpstarter.driversentry point injumpstarter-driver-opendal
python/packages/jumpstarter-driver-opendal/pyproject.toml(line 18) registers only[project.entry-points."jumpstarter.adapters"]and has no corresponding[project.entry-points."jumpstarter.drivers"], despite this being a driver package.- Either add the missing
jumpstarter.driversentry point so theOpendaldriver is discoverable (while keeping adapter registration if needed), or explicitly document why this package intentionally does not usejumpstarter.drivers.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@python/packages/jumpstarter-driver-opendal/pyproject.toml` at line 18, Add the missing entry point group for the driver so the Opendal driver is discoverable: in the pyproject.toml for the jumpstarter-driver-opendal package, add a [project.entry-points."jumpstarter.drivers"] section that registers the Opendal driver class (the concrete driver symbol used in this package) alongside or in addition to the existing [project.entry-points."jumpstarter.adapters"] registration; alternatively, if the package intentionally does not expose a driver, add a short comment or README note in the package explaining why no [project.entry-points."jumpstarter.drivers"] entry exists so maintainers know this is deliberate.Source: Coding guidelines
cb5f521 to
d114931
Compare
Pillow Build Failure on Python 3.14The CI is failing because Pillow doesn't have pre-built wheels for Python 3.14 yet, so it's trying to build from source but the runners are missing required system libraries. Proposed Solution: Install System DependenciesAdd the required build dependencies to the CI workflow for Python 3.14: Ubuntu: - name: Install system dependencies for Pillow (Python 3.14)
if: matrix.python-version == '3.14'
run: |
sudo apt-get update
sudo apt-get install -y libjpeg-dev zlib1g-dev libtiff-dev libfreetype6-dev liblcms2-dev libwebp-dev libopenjp2-7-devmacOS: - name: Install system dependencies for Pillow (Python 3.14)
if: matrix.python-version == '3.14'
run: |
brew install libjpeg libtiff little-cms2 webpThis is the most robust approach and ensures Pillow builds correctly from source until official wheels are available. Error from CI: |
sound good, doing it as part of this PR should work. |
Head branch was pushed to by a user without write access
|
Checking CI with scipy build dependencies added |
Build Dependencies AddedAdded system build dependencies for Python 3.14 to both test workflows: Python Tests (
|
|
@jtligon still some build issues on MacOS https://github.com/jumpstarter-dev/jumpstarter/actions/runs/27573913764/job/81607564175?pr=775#step:15:276 |
macOS gfortran fix appliedAdded a symlink to make Latest commit: 435565b Note: macOS 3.12 test failureThe macOS 3.12 job is failing on |
6e823e2 to
9be0da5
Compare
9be0da5 to
dad0ecd
Compare
|
Removed the test fix as requested. The flaky test will be handled in a separate PR. |
062a5bf to
390930a
Compare
|
Trying to rebase this claude is having a hard time... I will try myself from dad0ecd otherwise. |
390930a to
766955b
Compare
- Update requires-python from >=3.11 to >=3.12 across all packages - Update ruff target-version to py312 - Update CI pytest matrix to test 3.12, 3.13, 3.14 - Add Python 3.14 build dependencies for Pillow and scipy - Remove duplicate pytest-asyncio in jumpstarter-driver-http - Add missing Apache-2.0 license to jumpstarter-driver-iscsi - Update uv.lock with Python 3.14 compatible dependencies
766955b to
4880fdc
Compare
|
The CI is failing because building Fix: Add Add this block right after the pytest-matrix:
needs: changes
if: needs.changes.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch'
runs-on: ${{ matrix.runs-on }}
env:
# Building packages like grpcio and scipy from source (required for
# Python 3.14 until upstream ships wheels) can exceed the default 300s
# uv lock timeout. 30 minutes gives enough headroom.
UV_LOCK_TIMEOUT: 1800
strategy: |
Building packages like grpcio and scipy from source on Python 3.14 can exceed the default 300s uv lock timeout. Increase to 30 minutes.
so uv has a lock on the cache, but we are building grpc and scipy (we may want to stop testing imagehash on 3.14 until they have prebuilt binnaries everywhere perhaps..) |
Add Python 3.14 Support
Summary
Adds support for Python 3.14 while maintaining backward compatibility with Python 3.12 and 3.13.
Changes
requires-pythonfrom>=3.11to>=3.12(65 packages)target-versiontopy312uv.lockwith Python 3.14 compatible dependenciesDependencies
This required upgrading to newer versions of packages with Python 3.14 support:
pydantic-core: 2.33.2 → 2.46.4 (has Python 3.14 wheels)pydantic: 2.11.7 → 2.13.4Additional Fixes
Fixed pre-existing issues identified by CodeRabbit:
Build Requirements
Building with Python 3.14 requires:
PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1for Rust-based Python extensionsbrew install gcc(provides gfortran for scipy)brew install openblas(required for scipy)export PKG_CONFIG_PATH="/opt/homebrew/opt/openblas/lib/pkgconfig:$PKG_CONFIG_PATH"Testing
uv sync --all-packages --all-extrasjmpCLI works correctly on Python 3.14.5Notes
Python 3.14 was released recently, so some packages in the ecosystem are still catching up. The forward compatibility flag allows PyO3-based packages to build using the stable ABI. Python 3.12 and 3.13 continue to work without any special configuration.
Checklist
pyproject.tomlfiles updated