Skip to content

chore: upgrade to Python 3.14#775

Open
jtligon wants to merge 2 commits into
jumpstarter-dev:mainfrom
jtligon:upgrade-python-3.14
Open

chore: upgrade to Python 3.14#775
jtligon wants to merge 2 commits into
jumpstarter-dev:mainfrom
jtligon:upgrade-python-3.14

Conversation

@jtligon

@jtligon jtligon commented Jun 8, 2026

Copy link
Copy Markdown

Add Python 3.14 Support

Summary

Adds support for Python 3.14 while maintaining backward compatibility with Python 3.12 and 3.13.

Changes

  • Updated requires-python from >=3.11 to >=3.12 (65 packages)
  • Updated ruff target-version to py312
  • Updated GitHub Actions CI to test with Python 3.12, 3.13, and 3.14
  • Updated uv.lock with Python 3.14 compatible dependencies

Dependencies

This required upgrading to newer versions of packages with Python 3.14 support:

  • pydantic-core: 2.33.2 → 2.46.4 (has Python 3.14 wheels)
  • pydantic: 2.11.7 → 2.13.4

Additional Fixes

Fixed pre-existing issues identified by CodeRabbit:

  • Added missing Apache-2.0 license to jumpstarter-driver-iscsi
  • Removed duplicate pytest-asyncio dependency in jumpstarter-driver-http
  • Fixed jumpstarter-driver-opendal entry point group (adapters → drivers)

Build Requirements

Building with Python 3.14 requires:

  • Environment variable: PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 for Rust-based Python extensions
  • macOS:
    • brew install gcc (provides gfortran for scipy)
    • brew install openblas (required for scipy)
    • export PKG_CONFIG_PATH="/opt/homebrew/opt/openblas/lib/pkgconfig:$PKG_CONFIG_PATH"
  • Linux: Install equivalent packages via system package manager

Testing

  • ✅ Successfully synced all packages with uv sync --all-packages --all-extras
  • ✅ Verified jmp CLI works correctly on Python 3.14.5
  • ✅ Backward compatible: supports Python 3.12, 3.13, and 3.14

Notes

Python 3.14 was released recently, so some packages in the ecosystem are still catching up. The forward compatibility flag allows PyO3-based packages to build using the stable ABI. Python 3.12 and 3.13 continue to work without any special configuration.

Checklist

  • All pyproject.toml files updated
  • CI configuration updated to test all versions
  • Dependencies resolved and lockfile updated
  • Local testing completed on Python 3.14
  • Backward compatibility maintained
  • CI passes

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Repository baseline is updated to Python 3.12: local pin, CI pytest matrix (3.12–3.14), Ruff target, example projects, and package manifests across core packages and all driver packages adjust requires-python to >=3.12. CI gains Python 3.14 Pillow build dependency steps. HTTP driver dev dependency and iSCSI license metadata are updated.

Changes

Python 3.12 baseline rollout

Layer / File(s) Summary
CI and tooling baseline set to 3.12–3.14
.py-version, .github/workflows/python-tests.yaml, python/pyproject.toml
Repository Python pin updated to 3.14, GitHub Actions pytest matrix expanded to 3.12–3.14 with OS-specific Pillow build dependency installation for Python 3.14, and Ruff linter target bumped to py312.
Examples and core packages requires-python updates
python/examples/*, python/packages/jumpstarter-all/*, python/packages/jumpstarter-cli*/*, python/packages/jumpstarter-kubernetes/*, python/packages/jumpstarter-imagehash/*, python/packages/jumpstarter-mcp/*, python/packages/jumpstarter-protocol/*, python/packages/jumpstarter-testing/*, python/packages/jumpstarter/pyproject.toml, python/packages/hatch-pin-jumpstarter/*
Example projects and core packages update requires-python from >=3.11 to >=3.12 across the repository.
Driver packages and template requires-python updates with metadata adjustments
python/packages/jumpstarter-driver-*/pyproject.toml, python/__templates__/driver/pyproject.toml.tmpl
All driver packages and driver template raise requires-python to >=3.12. HTTP driver bumps pytest-asyncio from >=0.0.0 to >=0.24.0; iSCSI driver adds license = "Apache-2.0" metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • NickCao

A rabbit skipped through version lines,
From 3.11 to 3.12 with design,
CI and drivers all aligned,
Pillow builds for 3.14 refined. 🐰
The baseline hops toward better times!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: upgrading Python support to version 3.14, which is the primary objective of this PR.
Description check ✅ Passed The description comprehensively explains the changes, including the Python version updates, dependency upgrades, build requirements, testing results, and bug fixes identified during the upgrade process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
python/packages/jumpstarter-driver-iscsi/pyproject.toml (1)

1-8: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add required Apache-2.0 license metadata to this package.

[project] is missing license = "Apache-2.0", which violates the repository packaging policy.

Suggested fix
 [project]
 name = "jumpstarter-driver-iscsi"
 dynamic = ["version", "urls"]
 description = "Exporter ISCSI service driver"
 readme = "README.md"
+license = "Apache-2.0"
 authors = [{ name = "Benny Zlotnik", email = "bzlotnik@redhat.com" }]
 requires-python = ">=3.14"

As per coding guidelines, “All packages must use Apache-2.0 license as specified in pyproject.toml”.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@python/packages/jumpstarter-driver-iscsi/pyproject.toml` around lines 1 - 8,
Add the required Apache-2.0 license metadata to the pyproject.toml [project]
metadata: update the project table in "pyproject.toml" (the [project] block for
the package jumpstarter-driver-iscsi) to include license = "Apache-2.0" so the
package metadata complies with repository packaging policy; place the new
license field alongside existing keys like name, dynamic, description, readme,
authors, and requires-python.

Source: Coding guidelines

python/packages/jumpstarter-driver-http/pyproject.toml (1)

41-42: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove duplicate pytest-asyncio constraints in dev dependencies.

Having both pytest-asyncio>=0.0.0 and pytest-asyncio>=0.24.0 is redundant and can confuse dependency resolution intent; keep only the stricter constraint.

Suggested cleanup
 [dependency-groups]
 dev = [
     "pytest-cov>=6.0.0",
     "pytest>=8.3.3",
-    "pytest-asyncio>=0.0.0",
     "pytest-asyncio>=0.24.0",
 ]
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@python/packages/jumpstarter-driver-http/pyproject.toml` around lines 41 - 42,
Remove the duplicate pytest-asyncio entries from the dev dependencies in
pyproject.toml by deleting the weaker constraint "pytest-asyncio>=0.0.0" and
keeping the stricter "pytest-asyncio>=0.24.0" (ensure the duplicate string
entries under the dev-dependencies section are consolidated so only the >=0.24.0
constraint remains).
python/packages/jumpstarter-driver-opendal/pyproject.toml (1)

18-20: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Register this package under jumpstarter.drivers (or rename/scope it if it is adapter-only).

For a jumpstarter-driver-* package, the required project.entry-points."jumpstarter.drivers" registration is missing.

As per coding guidelines, “Drivers must register via jumpstarter.drivers entry point in pyproject.toml”.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@python/packages/jumpstarter-driver-opendal/pyproject.toml` around lines 18 -
20, The pyproject.toml registers the package under
project.entry-points."jumpstarter.adapters" but for a jumpstarter-driver-*
package it must register under project.entry-points."jumpstarter.drivers";
update the entry-point group to "jumpstarter.drivers" (or if this package is
strictly an adapter, rename/scope the package accordingly) and ensure the entry
maps the OpendalAdapter symbol
(jumpstarter_driver_opendal.adapters:OpendalAdapter) under that group so the
driver is discoverable.

Sources: Coding guidelines, Learnings

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@python/packages/jumpstarter-driver-http/pyproject.toml`:
- Around line 41-42: Remove the duplicate pytest-asyncio entries from the dev
dependencies in pyproject.toml by deleting the weaker constraint
"pytest-asyncio>=0.0.0" and keeping the stricter "pytest-asyncio>=0.24.0"
(ensure the duplicate string entries under the dev-dependencies section are
consolidated so only the >=0.24.0 constraint remains).

In `@python/packages/jumpstarter-driver-iscsi/pyproject.toml`:
- Around line 1-8: Add the required Apache-2.0 license metadata to the
pyproject.toml [project] metadata: update the project table in "pyproject.toml"
(the [project] block for the package jumpstarter-driver-iscsi) to include
license = "Apache-2.0" so the package metadata complies with repository
packaging policy; place the new license field alongside existing keys like name,
dynamic, description, readme, authors, and requires-python.

In `@python/packages/jumpstarter-driver-opendal/pyproject.toml`:
- Around line 18-20: The pyproject.toml registers the package under
project.entry-points."jumpstarter.adapters" but for a jumpstarter-driver-*
package it must register under project.entry-points."jumpstarter.drivers";
update the entry-point group to "jumpstarter.drivers" (or if this package is
strictly an adapter, rename/scope the package accordingly) and ensure the entry
maps the OpendalAdapter symbol
(jumpstarter_driver_opendal.adapters:OpendalAdapter) under that group so the
driver is discoverable.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f69689ae-69d2-4fbc-8ba7-999be9c428c7

📥 Commits

Reviewing files that changed from the base of the PR and between be78b3b and 3282c04.

⛔ Files ignored due to path filters (1)
  • python/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (65)
  • .github/workflows/python-tests.yaml
  • .py-version
  • python/examples/android-emulator/pyproject.toml
  • python/examples/automotive/pyproject.toml
  • python/examples/soc-pytest/pyproject.toml
  • python/examples/xcp-ecu/pyproject.toml
  • python/packages/hatch-pin-jumpstarter/pyproject.toml
  • python/packages/jumpstarter-all/pyproject.toml
  • python/packages/jumpstarter-cli-admin/pyproject.toml
  • python/packages/jumpstarter-cli-common/pyproject.toml
  • python/packages/jumpstarter-cli-driver/pyproject.toml
  • python/packages/jumpstarter-cli/pyproject.toml
  • python/packages/jumpstarter-driver-adb/pyproject.toml
  • python/packages/jumpstarter-driver-androidemulator/pyproject.toml
  • python/packages/jumpstarter-driver-ble/pyproject.toml
  • python/packages/jumpstarter-driver-can/pyproject.toml
  • python/packages/jumpstarter-driver-composite/pyproject.toml
  • python/packages/jumpstarter-driver-corellium/pyproject.toml
  • python/packages/jumpstarter-driver-doip/pyproject.toml
  • python/packages/jumpstarter-driver-dut-network/pyproject.toml
  • python/packages/jumpstarter-driver-dutlink/pyproject.toml
  • python/packages/jumpstarter-driver-energenie/pyproject.toml
  • python/packages/jumpstarter-driver-esp32/pyproject.toml
  • python/packages/jumpstarter-driver-flashers/pyproject.toml
  • python/packages/jumpstarter-driver-gpiod/pyproject.toml
  • python/packages/jumpstarter-driver-http-power/pyproject.toml
  • python/packages/jumpstarter-driver-http/pyproject.toml
  • python/packages/jumpstarter-driver-iscsi/pyproject.toml
  • python/packages/jumpstarter-driver-mitmproxy/pyproject.toml
  • python/packages/jumpstarter-driver-network/pyproject.toml
  • python/packages/jumpstarter-driver-noyito-relay/pyproject.toml
  • python/packages/jumpstarter-driver-opendal/pyproject.toml
  • python/packages/jumpstarter-driver-pi-pico/pyproject.toml
  • python/packages/jumpstarter-driver-power/pyproject.toml
  • python/packages/jumpstarter-driver-probe-rs/pyproject.toml
  • python/packages/jumpstarter-driver-pyserial/pyproject.toml
  • python/packages/jumpstarter-driver-qemu/pyproject.toml
  • python/packages/jumpstarter-driver-renode/pyproject.toml
  • python/packages/jumpstarter-driver-ridesx/pyproject.toml
  • python/packages/jumpstarter-driver-sdwire/pyproject.toml
  • python/packages/jumpstarter-driver-shell/pyproject.toml
  • python/packages/jumpstarter-driver-snmp/pyproject.toml
  • python/packages/jumpstarter-driver-someip/pyproject.toml
  • python/packages/jumpstarter-driver-ssh-mitm/pyproject.toml
  • python/packages/jumpstarter-driver-ssh-mount/pyproject.toml
  • python/packages/jumpstarter-driver-ssh/pyproject.toml
  • python/packages/jumpstarter-driver-stlink-msd/pyproject.toml
  • python/packages/jumpstarter-driver-tasmota/pyproject.toml
  • python/packages/jumpstarter-driver-tftp/pyproject.toml
  • python/packages/jumpstarter-driver-tmt/pyproject.toml
  • python/packages/jumpstarter-driver-uboot/pyproject.toml
  • python/packages/jumpstarter-driver-uds-can/pyproject.toml
  • python/packages/jumpstarter-driver-uds-doip/pyproject.toml
  • python/packages/jumpstarter-driver-uds/pyproject.toml
  • python/packages/jumpstarter-driver-ustreamer/pyproject.toml
  • python/packages/jumpstarter-driver-vnc/pyproject.toml
  • python/packages/jumpstarter-driver-xcp/pyproject.toml
  • python/packages/jumpstarter-driver-yepkit/pyproject.toml
  • python/packages/jumpstarter-imagehash/pyproject.toml
  • python/packages/jumpstarter-kubernetes/pyproject.toml
  • python/packages/jumpstarter-mcp/pyproject.toml
  • python/packages/jumpstarter-protocol/pyproject.toml
  • python/packages/jumpstarter-testing/pyproject.toml
  • python/packages/jumpstarter/pyproject.toml
  • python/pyproject.toml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@python/packages/jumpstarter-driver-shell/pyproject.toml`:
- Line 7: Update the Python driver template's pyproject setting: locate the
requires-python entry in python/__templates__/driver/pyproject.toml.tmpl (used
by python/__templates__/create_driver.sh) and change requires-python = ">=3.11"
to requires-python = ">=3.12" so newly generated drivers match existing
packages; verify no other template copies still use ">=3.11".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1902221a-cbd7-4ae7-b4ed-a776da798944

📥 Commits

Reviewing files that changed from the base of the PR and between 3282c04 and 9b320c1.

📒 Files selected for processing (65)
  • .github/workflows/python-tests.yaml
  • PR_DESCRIPTION.md
  • python/examples/android-emulator/pyproject.toml
  • python/examples/automotive/pyproject.toml
  • python/examples/soc-pytest/pyproject.toml
  • python/examples/xcp-ecu/pyproject.toml
  • python/packages/hatch-pin-jumpstarter/pyproject.toml
  • python/packages/jumpstarter-all/pyproject.toml
  • python/packages/jumpstarter-cli-admin/pyproject.toml
  • python/packages/jumpstarter-cli-common/pyproject.toml
  • python/packages/jumpstarter-cli-driver/pyproject.toml
  • python/packages/jumpstarter-cli/pyproject.toml
  • python/packages/jumpstarter-driver-adb/pyproject.toml
  • python/packages/jumpstarter-driver-androidemulator/pyproject.toml
  • python/packages/jumpstarter-driver-ble/pyproject.toml
  • python/packages/jumpstarter-driver-can/pyproject.toml
  • python/packages/jumpstarter-driver-composite/pyproject.toml
  • python/packages/jumpstarter-driver-corellium/pyproject.toml
  • python/packages/jumpstarter-driver-doip/pyproject.toml
  • python/packages/jumpstarter-driver-dut-network/pyproject.toml
  • python/packages/jumpstarter-driver-dutlink/pyproject.toml
  • python/packages/jumpstarter-driver-energenie/pyproject.toml
  • python/packages/jumpstarter-driver-esp32/pyproject.toml
  • python/packages/jumpstarter-driver-flashers/pyproject.toml
  • python/packages/jumpstarter-driver-gpiod/pyproject.toml
  • python/packages/jumpstarter-driver-http-power/pyproject.toml
  • python/packages/jumpstarter-driver-http/pyproject.toml
  • python/packages/jumpstarter-driver-iscsi/pyproject.toml
  • python/packages/jumpstarter-driver-mitmproxy/pyproject.toml
  • python/packages/jumpstarter-driver-network/pyproject.toml
  • python/packages/jumpstarter-driver-noyito-relay/pyproject.toml
  • python/packages/jumpstarter-driver-opendal/pyproject.toml
  • python/packages/jumpstarter-driver-pi-pico/pyproject.toml
  • python/packages/jumpstarter-driver-power/pyproject.toml
  • python/packages/jumpstarter-driver-probe-rs/pyproject.toml
  • python/packages/jumpstarter-driver-pyserial/pyproject.toml
  • python/packages/jumpstarter-driver-qemu/pyproject.toml
  • python/packages/jumpstarter-driver-renode/pyproject.toml
  • python/packages/jumpstarter-driver-ridesx/pyproject.toml
  • python/packages/jumpstarter-driver-sdwire/pyproject.toml
  • python/packages/jumpstarter-driver-shell/pyproject.toml
  • python/packages/jumpstarter-driver-snmp/pyproject.toml
  • python/packages/jumpstarter-driver-someip/pyproject.toml
  • python/packages/jumpstarter-driver-ssh-mitm/pyproject.toml
  • python/packages/jumpstarter-driver-ssh-mount/pyproject.toml
  • python/packages/jumpstarter-driver-ssh/pyproject.toml
  • python/packages/jumpstarter-driver-stlink-msd/pyproject.toml
  • python/packages/jumpstarter-driver-tasmota/pyproject.toml
  • python/packages/jumpstarter-driver-tftp/pyproject.toml
  • python/packages/jumpstarter-driver-tmt/pyproject.toml
  • python/packages/jumpstarter-driver-uboot/pyproject.toml
  • python/packages/jumpstarter-driver-uds-can/pyproject.toml
  • python/packages/jumpstarter-driver-uds-doip/pyproject.toml
  • python/packages/jumpstarter-driver-uds/pyproject.toml
  • python/packages/jumpstarter-driver-ustreamer/pyproject.toml
  • python/packages/jumpstarter-driver-vnc/pyproject.toml
  • python/packages/jumpstarter-driver-xcp/pyproject.toml
  • python/packages/jumpstarter-driver-yepkit/pyproject.toml
  • python/packages/jumpstarter-imagehash/pyproject.toml
  • python/packages/jumpstarter-kubernetes/pyproject.toml
  • python/packages/jumpstarter-mcp/pyproject.toml
  • python/packages/jumpstarter-protocol/pyproject.toml
  • python/packages/jumpstarter-testing/pyproject.toml
  • python/packages/jumpstarter/pyproject.toml
  • python/pyproject.toml
✅ Files skipped from review due to trivial changes (11)
  • PR_DESCRIPTION.md
  • python/packages/jumpstarter-driver-someip/pyproject.toml
  • python/examples/android-emulator/pyproject.toml
  • python/packages/hatch-pin-jumpstarter/pyproject.toml
  • python/packages/jumpstarter-protocol/pyproject.toml
  • python/packages/jumpstarter-driver-androidemulator/pyproject.toml
  • python/packages/jumpstarter-driver-xcp/pyproject.toml
  • python/packages/jumpstarter-driver-esp32/pyproject.toml
  • python/packages/jumpstarter-driver-ssh-mount/pyproject.toml
  • python/packages/jumpstarter-driver-composite/pyproject.toml
  • python/packages/jumpstarter-kubernetes/pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (22)
  • python/packages/jumpstarter-driver-vnc/pyproject.toml
  • python/packages/jumpstarter-driver-noyito-relay/pyproject.toml
  • python/packages/jumpstarter-cli-admin/pyproject.toml
  • python/packages/jumpstarter-cli-common/pyproject.toml
  • python/packages/jumpstarter-driver-network/pyproject.toml
  • python/packages/jumpstarter-driver-mitmproxy/pyproject.toml
  • python/packages/jumpstarter-driver-ustreamer/pyproject.toml
  • python/packages/jumpstarter-driver-corellium/pyproject.toml
  • python/examples/automotive/pyproject.toml
  • python/packages/jumpstarter/pyproject.toml
  • python/packages/jumpstarter-driver-ridesx/pyproject.toml
  • python/packages/jumpstarter-driver-flashers/pyproject.toml
  • python/packages/jumpstarter-driver-ssh/pyproject.toml
  • python/packages/jumpstarter-driver-uds-can/pyproject.toml
  • python/packages/jumpstarter-driver-renode/pyproject.toml
  • python/packages/jumpstarter-cli-driver/pyproject.toml
  • python/packages/jumpstarter-driver-uds/pyproject.toml
  • python/packages/jumpstarter-testing/pyproject.toml
  • python/packages/jumpstarter-driver-doip/pyproject.toml
  • python/packages/jumpstarter-driver-tasmota/pyproject.toml
  • python/examples/soc-pytest/pyproject.toml
  • python/packages/jumpstarter-driver-pyserial/pyproject.toml

Comment thread python/packages/jumpstarter-driver-shell/pyproject.toml
Comment thread PR_DESCRIPTION.md Outdated

@mangelajo mangelajo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of tiny comments. Thanks @jtligon !

Comment thread python/packages/jumpstarter-driver-opendal/pyproject.toml Outdated
Comment thread python/packages/jumpstarter-driver-shell/pyproject.toml
Comment thread PR_DESCRIPTION.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@python/packages/jumpstarter-driver-opendal/pyproject.toml`:
- Line 18: Add the missing entry point group for the driver so the Opendal
driver is discoverable: in the pyproject.toml for the jumpstarter-driver-opendal
package, add a [project.entry-points."jumpstarter.drivers"] section that
registers the Opendal driver class (the concrete driver symbol used in this
package) alongside or in addition to the existing
[project.entry-points."jumpstarter.adapters"] registration; alternatively, if
the package intentionally does not expose a driver, add a short comment or
README note in the package explaining why no
[project.entry-points."jumpstarter.drivers"] entry exists so maintainers know
this is deliberate.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f56550fc-29ec-425d-9816-eec8940497ea

📥 Commits

Reviewing files that changed from the base of the PR and between 9b320c1 and cb5f521.

📒 Files selected for processing (2)
  • python/__templates__/driver/pyproject.toml.tmpl
  • python/packages/jumpstarter-driver-opendal/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • python/templates/driver/pyproject.toml.tmpl

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@python/packages/jumpstarter-driver-opendal/pyproject.toml`:
- Line 18: Add the missing entry point group for the driver so the Opendal
driver is discoverable: in the pyproject.toml for the jumpstarter-driver-opendal
package, add a [project.entry-points."jumpstarter.drivers"] section that
registers the Opendal driver class (the concrete driver symbol used in this
package) alongside or in addition to the existing
[project.entry-points."jumpstarter.adapters"] registration; alternatively, if
the package intentionally does not expose a driver, add a short comment or
README note in the package explaining why no
[project.entry-points."jumpstarter.drivers"] entry exists so maintainers know
this is deliberate.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f56550fc-29ec-425d-9816-eec8940497ea

📥 Commits

Reviewing files that changed from the base of the PR and between 9b320c1 and cb5f521.

📒 Files selected for processing (2)
  • python/__templates__/driver/pyproject.toml.tmpl
  • python/packages/jumpstarter-driver-opendal/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • python/templates/driver/pyproject.toml.tmpl
🛑 Comments failed to post (1)
python/packages/jumpstarter-driver-opendal/pyproject.toml (1)

18-18: ⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check entry point registration patterns across all driver packages

# Find all driver package pyproject.toml files and show their entry points
fd -t f 'pyproject.toml' 'python/packages/jumpstarter-driver-*' --exec sh -c '
  echo "=== {} ==="
  rg -A2 "project.entry-points" {} || echo "No entry-points found"
  echo
'

Repository: jumpstarter-dev/jumpstarter

Length of output: 195


Fix missing jumpstarter.drivers entry point in jumpstarter-driver-opendal

  • python/packages/jumpstarter-driver-opendal/pyproject.toml (line 18) registers only [project.entry-points."jumpstarter.adapters"] and has no corresponding [project.entry-points."jumpstarter.drivers"], despite this being a driver package.
  • Either add the missing jumpstarter.drivers entry point so the Opendal driver is discoverable (while keeping adapter registration if needed), or explicitly document why this package intentionally does not use jumpstarter.drivers.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@python/packages/jumpstarter-driver-opendal/pyproject.toml` at line 18, Add
the missing entry point group for the driver so the Opendal driver is
discoverable: in the pyproject.toml for the jumpstarter-driver-opendal package,
add a [project.entry-points."jumpstarter.drivers"] section that registers the
Opendal driver class (the concrete driver symbol used in this package) alongside
or in addition to the existing [project.entry-points."jumpstarter.adapters"]
registration; alternatively, if the package intentionally does not expose a
driver, add a short comment or README note in the package explaining why no
[project.entry-points."jumpstarter.drivers"] entry exists so maintainers know
this is deliberate.

Source: Coding guidelines

@jtligon jtligon requested a review from mangelajo June 9, 2026 12:42
@jtligon jtligon force-pushed the upgrade-python-3.14 branch from cb5f521 to d114931 Compare June 10, 2026 12:33
@mangelajo mangelajo enabled auto-merge (squash) June 10, 2026 13:38
@jtligon

jtligon commented Jun 11, 2026

Copy link
Copy Markdown
Author

Pillow Build Failure on Python 3.14

The CI is failing because Pillow doesn't have pre-built wheels for Python 3.14 yet, so it's trying to build from source but the runners are missing required system libraries.

Proposed Solution: Install System Dependencies

Add the required build dependencies to the CI workflow for Python 3.14:

Ubuntu:

- name: Install system dependencies for Pillow (Python 3.14)
  if: matrix.python-version == '3.14'
  run: |
    sudo apt-get update
    sudo apt-get install -y libjpeg-dev zlib1g-dev libtiff-dev libfreetype6-dev liblcms2-dev libwebp-dev libopenjp2-7-dev

macOS:

- name: Install system dependencies for Pillow (Python 3.14)
  if: matrix.python-version == '3.14'
  run: |
    brew install libjpeg libtiff little-cms2 webp

This is the most robust approach and ensures Pillow builds correctly from source until official wheels are available.

Error from CI:

The headers or library files could not be found for jpeg,
a required dependency when compiling Pillow from source.

@mangelajo

Copy link
Copy Markdown
Member

Pillow Build Failure on Python 3.14

The CI is failing because Pillow doesn't have pre-built wheels for Python 3.14 yet, so it's trying to build from source but the runners are missing required system libraries.

Proposed Solution: Install System Dependencies

Add the required build dependencies to the CI workflow for Python 3.14:

Ubuntu:

- name: Install system dependencies for Pillow (Python 3.14)
  if: matrix.python-version == '3.14'
  run: |
    sudo apt-get update
    sudo apt-get install -y libjpeg-dev zlib1g-dev libtiff-dev libfreetype6-dev liblcms2-dev libwebp-dev libopenjp2-7-dev

macOS:

- name: Install system dependencies for Pillow (Python 3.14)
  if: matrix.python-version == '3.14'
  run: |
    brew install libjpeg libtiff little-cms2 webp

This is the most robust approach and ensures Pillow builds correctly from source until official wheels are available.

Error from CI:

The headers or library files could not be found for jpeg,
a required dependency when compiling Pillow from source.

sound good, doing it as part of this PR should work.

@mangelajo mangelajo self-requested a review June 15, 2026 07:34
auto-merge was automatically disabled June 15, 2026 13:22

Head branch was pushed to by a user without write access

@jtligon

jtligon commented Jun 15, 2026

Copy link
Copy Markdown
Author

Checking CI with scipy build dependencies added

@jtligon

jtligon commented Jun 15, 2026

Copy link
Copy Markdown
Author

Build Dependencies Added

Added system build dependencies for Python 3.14 to both test workflows:

Python Tests (python-tests.yaml)

  • Ubuntu & macOS (conditional on Python 3.14):
    • Pillow: libjpeg-dev, zlib1g-dev, libtiff-dev, libfreetype6-dev, liblcms2-dev, libwebp-dev, libopenjp2-7-dev
    • scipy: gfortran, libopenblas-dev, liblapack-dev, pkg-config (Ubuntu) / gcc, openblas (macOS)

E2E Tests (e2e.yaml)

  • All jobs using .py-version (which is now 3.14):
    • e2e-tests
    • e2e-compat-old-controller
    • e2e-compat-old-client
    • Same Pillow + scipy dependencies as above

Once a maintainer approves the workflow runs, CI should pass. Both Pillow and scipy currently lack Python 3.14 wheels, so they must build from source.

Tracking: Issue #795 and draft PR #796 are set up to remove these dependencies once wheels become available.

@mangelajo mangelajo enabled auto-merge (squash) June 16, 2026 07:55
@mangelajo

Copy link
Copy Markdown
Member

Comment thread .py-version Outdated
@mangelajo mangelajo added this to the 0.9.0 milestone Jun 23, 2026
@jtligon

jtligon commented Jun 23, 2026

Copy link
Copy Markdown
Author

macOS gfortran fix applied

Added a symlink to make gfortran discoverable by scipy's meson build on macOS. Homebrew's gcc provides version-specific binaries like gfortran-14, but scipy expects gfortran.

Latest commit: 435565b

Note: macOS 3.12 test failure

The macOS 3.12 job is failing on test_drain_exits_when_deadline_exceeded_before_select - this is a flaky timing test unrelated to the Python 3.14 upgrade. The same test passes on macOS 3.13 and Ubuntu 3.12/3.13/3.14.

@jtligon jtligon force-pushed the upgrade-python-3.14 branch 3 times, most recently from 6e823e2 to 9be0da5 Compare June 23, 2026 15:24
Comment thread python/packages/jumpstarter/jumpstarter/exporter/hooks_test.py Outdated
@jtligon jtligon force-pushed the upgrade-python-3.14 branch from 9be0da5 to dad0ecd Compare June 23, 2026 15:42
@jtligon

jtligon commented Jun 23, 2026

Copy link
Copy Markdown
Author

Removed the test fix as requested. The flaky test will be handled in a separate PR.

@mangelajo mangelajo force-pushed the upgrade-python-3.14 branch 2 times, most recently from 062a5bf to 390930a Compare June 23, 2026 20:28
@mangelajo

Copy link
Copy Markdown
Member

Trying to rebase this claude is having a hard time... I will try myself from dad0ecd otherwise.

@mangelajo mangelajo force-pushed the upgrade-python-3.14 branch from 390930a to 766955b Compare June 23, 2026 20:37
@mangelajo mangelajo disabled auto-merge June 23, 2026 20:47
@mangelajo mangelajo enabled auto-merge June 23, 2026 20:47
@mangelajo mangelajo added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@mangelajo mangelajo added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
- Update requires-python from >=3.11 to >=3.12 across all packages
- Update ruff target-version to py312
- Update CI pytest matrix to test 3.12, 3.13, 3.14
- Add Python 3.14 build dependencies for Pillow and scipy
- Remove duplicate pytest-asyncio in jumpstarter-driver-http
- Add missing Apache-2.0 license to jumpstarter-driver-iscsi
- Update uv.lock with Python 3.14 compatible dependencies
@mangelajo mangelajo force-pushed the upgrade-python-3.14 branch from 766955b to 4880fdc Compare June 23, 2026 22:14
@mangelajo mangelajo enabled auto-merge June 23, 2026 22:21
@mangelajo mangelajo added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@mangelajo mangelajo added this pull request to the merge queue Jun 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 24, 2026
@mangelajo mangelajo added this pull request to the merge queue Jun 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 24, 2026
@mangelajo mangelajo added this pull request to the merge queue Jun 24, 2026
@mangelajo mangelajo removed this pull request from the merge queue due to the queue being cleared Jun 24, 2026
@mangelajo

Copy link
Copy Markdown
Member

The CI is failing because building grpcio and scipy from source (no Python 3.14 wheels yet) exceeds uv's default 300s lock timeout.

Fix: Add UV_LOCK_TIMEOUT: 1800 (30 minutes) as a job-level env var on pytest-matrix. This gives enough headroom for source builds.

Add this block right after the runs-on: line in the pytest-matrix job:

  pytest-matrix:
    needs: changes
    if: needs.changes.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch'
    runs-on: ${{ matrix.runs-on }}
    env:
      # Building packages like grpcio and scipy from source (required for
      # Python 3.14 until upstream ships wheels) can exceed the default 300s
      # uv lock timeout. 30 minutes gives enough headroom.
      UV_LOCK_TIMEOUT: 1800
    strategy:

Building packages like grpcio and scipy from source on Python 3.14
can exceed the default 300s uv lock timeout. Increase to 30 minutes.
@mangelajo

Copy link
Copy Markdown
Member

The CI is failing because building grpcio and scipy from source (no Python 3.14 wheels yet) exceeds uv's default 300s lock timeout.

Fix: Add UV_LOCK_TIMEOUT: 1800 (30 minutes) as a job-level env var on pytest-matrix. This gives enough headroom for source builds.

Add this block right after the runs-on: line in the pytest-matrix job:

  pytest-matrix:
    needs: changes
    if: needs.changes.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch'
    runs-on: ${{ matrix.runs-on }}
    env:
      # Building packages like grpcio and scipy from source (required for
      # Python 3.14 until upstream ships wheels) can exceed the default 300s
      # uv lock timeout. 30 minutes gives enough headroom.
      UV_LOCK_TIMEOUT: 1800
    strategy:

so uv has a lock on the cache, but we are building grpc and scipy (we may want to stop testing imagehash on 3.14 until they have prebuilt binnaries everywhere perhaps..)

@mangelajo mangelajo enabled auto-merge June 24, 2026 07:35
@mangelajo mangelajo added this pull request to the merge queue Jun 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants