feat: add Ghostty as a supported SSH/Telnet terminal on macOS - #351
Open
Wisdom12333 wants to merge 1 commit into
Open
feat: add Ghostty as a supported SSH/Telnet terminal on macOS#351Wisdom12333 wants to merge 1 commit into
Wisdom12333 wants to merge 1 commit into
Conversation
Adds a new built-in macOS plugin for Ghostty alongside Terminal.app and iTerm2. Ghostty has no "do script" AppleEvent, so the SSH launch path drives it through its own AppleScript dictionary instead of `open -na --args`, which avoids a security confirmation dialog and a broken extra tab that appear once Ghostty is already running. Repeat connections land as tabs in the existing window instead of new windows.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
open -na --args -eonly cold-starts cleanly once — a second connection while it's already running triggers a native "Allow Ghostty to execute...?" confirmation and, if approved, opens a broken extra tab. The SSH launch path (go-client/pkg/awaken/awaken_darwin.go) instead drives Ghostty through its own AppleScript dictionary (new surface configuration/new tab in ... with configuration/new window with configuration), which works identically whether Ghostty is cold or already running, with no confirmation dialog.plugins/macos/macos.ghostty/), registers it inplugins/macos/index.json, wires up the Settings UI icon, and updates README/README_CN/docs to mention Ghostty as a supported terminal.Test plan
go build ./... && go vet ./... && go test ./...ingo-client— all passcargo check --releaseinsrc-tauri— clean (only pre-existing, unrelated warnings).applocally (Tauri release build) and verified against a real JumpServer server: