Skip to content

Conversation

@agilevic
Copy link

@agilevic agilevic commented Nov 3, 2025

What kind of change does this PR introduce?

New blog post; invited to contribute by @jviotti
You can change the type to Engineering if more appropriate.

@agilevic agilevic requested a review from a team as a code owner November 3, 2025 21:21
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Hi @agilevic! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 9e30777

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (dcf4ea4) to head (9e30777).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1880   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jviotti
Copy link
Member

jviotti commented Nov 4, 2025

@json-schema-org/docs-team @json-schema-org/tsc Can you help with your own reviews for this blog post? @agilevic and I have been talking for a while and SlashDB is a very nice "database gateway" that generates JSON Schema. I think it will be a great addition for the case studies!

@agilevic
Copy link
Author

agilevic commented Nov 6, 2025

@jviotti do you want to unblock this? There is no issue reference to give. Thanks.

@jviotti
Copy link
Member

jviotti commented Nov 6, 2025

No worries. Feel free to ignore that check. But let me ping the team again for reviews

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. My only concern is that I'm not a fan of the "type": [whatever, "null"] pattern and I'm concerned that people are going to read this article and think that's a recommended way to describe optional properties. I think it would be helpful to explain why you need to support two different ways for a property to not be present (defined with null or not defined) and note that this is not typical and not always the right approach.

As a style suggestion, I found the schemas hard to read because they span multiple screens that I need to scroll through. I suggest using,

"type": ["string", "null"]

instead of,

"type": [
  "string",
  "null"
]

This will make the schemas significantly more compact and I think easier to read.

Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall an interesting article. It's neat that you've been able to integrate JSON Schema this tightly into the DB.

I do have some comments, but they're largely editorial. The base content looks great. Thanks for writing this up.

@Bhumikagarggg

This comment was marked as off-topic.

@github-actions
Copy link

Hi @agilevic! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@github-actions
Copy link

Hi @agilevic! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@agilevic
Copy link
Author

Thank you all for reviews. I have only now gotten around to make the edits. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready to review

Development

Successfully merging this pull request may close these issues.

5 participants