Skip to content

Prepare the 2.5.0 release #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscarle merged 1 commit into from
Mar 9, 2026
+31 −38
Merged

Prepare the 2.5.0 release #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEXT_RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Draft release description for x.x.x
# Draft release description for 2.5.0

## Breaking changes

Expand Down
2 changes: 1 addition & 1 deletion OnePassword.NET.Tests/AccountPreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public void GetAccount()
Assert.That(account.Domain, Is.EqualTo(AccountAddress[..AccountAddress.IndexOf('.', StringComparison.Ordinal)]));
Assert.That(account.Type, Is.Not.EqualTo(AccountType.Unknown));
Assert.That(account.State, Is.EqualTo(State.Active));
Assert.That(account.Created, Is.Not.EqualTo(default));
Assert.That(account.Created, Is.Not.EqualTo(default(DateTimeOffset)));
});
});
}
Expand Down
12 changes: 6 additions & 6 deletions OnePassword.NET.Tests/OnePassword.NET.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0"/>
<PackageReference Include="NUnit" Version="4.1.0"/>
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0"/>
<PackageReference Include="NUnit.Analyzers" Version="4.2.0"/>
<PackageReference Include="coverlet.collector" Version="6.0.2">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0"/>
<PackageReference Include="NUnit" Version="4.5.1"/>
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0"/>
<PackageReference Include="NUnit.Analyzers" Version="4.12.0"/>
<PackageReference Include="coverlet.collector" Version="8.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand All @@ -24,4 +24,4 @@
<Using Include="NUnit.Framework"/>
</ItemGroup>

</Project>
</Project>
8 changes: 4 additions & 4 deletions OnePassword.NET.Tests/SetUpGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ public void CreateGroup()
Assert.That(_initialGroup.Description, Is.EqualTo(InitialDescription));
Assert.That(_initialGroup.Type, Is.EqualTo(GroupType.User));
Assert.That(_initialGroup.State, Is.EqualTo(State.Inactive));
Assert.That(_initialGroup.Created, Is.Not.EqualTo(default));
Assert.That(_initialGroup.Updated, Is.Not.EqualTo(default));
Assert.That(_initialGroup.Created, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(_initialGroup.Updated, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(_initialGroup.Permissions, Has.Count.EqualTo(0));
});
});
Expand Down Expand Up @@ -107,8 +107,8 @@ public void GetGroup()
Assert.That(group.Description, Is.EqualTo(FinalDescription));
Assert.That(group.Type, Is.EqualTo(GroupType.User));
Assert.That(group.State, Is.EqualTo(State.Active));
Assert.That(group.Created, Is.Not.EqualTo(default));
Assert.That(group.Updated, Is.Not.EqualTo(default));
Assert.That(group.Created, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(group.Updated, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(group.Permissions, Has.Count.EqualTo(0));
});
});
Expand Down
12 changes: 6 additions & 6 deletions OnePassword.NET.Tests/SetUpUser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ public void ProvisionUser()
Assert.That(_initialUser.Email, Is.EqualTo(TestUserEmail));
Assert.That(_initialUser.Type, Is.EqualTo(UserType.Member));
Assert.That(_initialUser.State, Is.EqualTo(State.TransferPending));
Assert.That(_initialUser.Created, Is.Not.EqualTo(default));
Assert.That(_initialUser.Updated, Is.Not.EqualTo(default));
Assert.That(_initialUser.LastAuthentication, Is.EqualTo(null));
Assert.That(_initialUser.Created, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(_initialUser.Updated, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(_initialUser.LastAuthentication, Is.Null);
});
});
}
Expand Down Expand Up @@ -138,9 +138,9 @@ public void GetUser()
Assert.That(user.Email, Is.EqualTo(TestUserEmail));
Assert.That(user.Type, Is.EqualTo(UserType.Member));
Assert.That(user.State, Is.EqualTo(State.Active));
Assert.That(user.Created, Is.Not.EqualTo(default));
Assert.That(user.Updated, Is.Not.EqualTo(default));
Assert.That(user.LastAuthentication, Is.EqualTo(null));
Assert.That(user.Created, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(user.Updated, Is.Not.EqualTo(default(DateTimeOffset)));
Assert.That(user.LastAuthentication, Is.Null);
});
});
}
Expand Down
4 changes: 2 additions & 2 deletions OnePassword.NET.Tests/SetUpVault.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public void CreateVault()
Assert.That(_initialVault.Name, Is.EqualTo(InitialName));
Assert.That(_initialVault.Type, Is.EqualTo(VaultType.User));
Assert.That(_initialVault.Items, Is.EqualTo(0));
Assert.That(_initialVault.Created, Is.Not.EqualTo(default));
Assert.That(_initialVault.Created, Is.Not.EqualTo(default(DateTimeOffset)));
});
});
}
Expand Down Expand Up @@ -89,7 +89,7 @@ public void GetVault()
Assert.That(vault.Name, Is.EqualTo(FinalName));
Assert.That(vault.Type, Is.EqualTo(VaultType.User));
Assert.That(vault.Items, Is.EqualTo(0));
Assert.That(vault.Created, Is.Not.EqualTo(default));
Assert.That(vault.Created, Is.Not.EqualTo(default(DateTimeOffset)));
});
});
}
Expand Down
6 changes: 3 additions & 3 deletions OnePassword.NET.Tests/TestItems.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void CreateItem()
{
Assert.That(_initialItem.Id, Is.Not.Empty);
Assert.That(_initialItem.Title, Is.EqualTo(InitialTitle));
Assert.That(_initialItem.Created, Is.Not.EqualTo(default));
Assert.That(_initialItem.Created, Is.Not.EqualTo(default(DateTimeOffset?)));
Assert.That(_initialItem.Fields.First(x => x.Label == "username").Value, Is.EqualTo(InitialUsername));
Assert.That(_initialItem.Fields.First(x => x.Section?.Label == EditSection && x.Label == EditField).Type, Is.EqualTo(InitialType));
Assert.That(_initialItem.Fields.First(x => x.Section?.Label == EditSection && x.Label == EditField).Value, Is.EqualTo(InitialValue));
Expand Down Expand Up @@ -100,7 +100,7 @@ public void EditItem()
{
Assert.That(item.Id, Is.Not.Empty);
Assert.That(item.Title, Is.EqualTo(FinalTitle));
Assert.That(item.Created, Is.Not.EqualTo(default));
Assert.That(item.Created, Is.Not.EqualTo(default(DateTimeOffset?)));
Assert.That(item.Fields.First(x => x.Label == "username").Value, Is.EqualTo(FinalUsername));
Assert.That(item.Fields.First(x => x.Section?.Label == EditSection && x.Label == EditField).Type, Is.EqualTo(FinalType));
Assert.That(item.Fields.First(x => x.Section?.Label == EditSection && x.Label == EditField).Value, Is.EqualTo(FinalValue));
Expand Down Expand Up @@ -220,7 +220,7 @@ public void GetItem()
{
Assert.That(item.Id, Is.Not.Empty);
Assert.That(item.Title, Is.EqualTo(FinalTitle));
Assert.That(item.Created, Is.Not.EqualTo(default));
Assert.That(item.Created, Is.Not.EqualTo(default(DateTimeOffset?)));
Assert.That(item.Fields.First(x => x.Label == "username").Value, Is.EqualTo(FinalUsername));
Assert.That(item.Fields.First(x => x.Section?.Label == EditSection && x.Label == EditField).Value, Is.EqualTo(FinalValue));
Assert.That(item.Fields.First(x => x.Label == AddedField).Value, Is.EqualTo(AddedValue));
Expand Down
12 changes: 6 additions & 6 deletions OnePassword.NET/OnePassword.NET.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
<Company>Jean-Sebastien Carle</Company>
<Product>OnePassword.NET</Product>
<Description>1Password CLI Wrapper</Description>
<Version>2.4.4</Version>
<AssemblyVersion>2.4.4.0</AssemblyVersion>
<FileVersion>2.4.4.0</FileVersion>
<Version>2.5.0</Version>
<AssemblyVersion>2.5.0.0</AssemblyVersion>
<FileVersion>2.5.0.0</FileVersion>
<Copyright>Copyright © Jean-Sebastien Carle 2021-2025</Copyright>
<RepositoryUrl>https://github.com/jscarle/OnePassword.NET</RepositoryUrl>
<RepositoryType>git</RepositoryType>
Expand All @@ -35,12 +35,12 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.Collections.Immutable" Version="9.0.4" />
<PackageReference Include="System.Collections.Immutable" Version="10.0.3" />
<Using Include="System.Collections.Immutable" />
<Using Include="System.Text.Json.Serialization" />
<Using Include="System.Runtime.Serialization" />
<PackageReference Include="System.Text.Json" Version="6.0.11" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
<PackageReference Include="System.Text.Json" Version="10.0.3" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.103" PrivateAssets="All" />
<None Include="..\LICENSE.md">
<Pack>True</Pack>
<PackagePath>\</PackagePath>
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This library targets .NET Standard 2.1.

This library has no dependencies.

## Breaking changes for the next x.x.x release
## Breaking changes for 2.5.0

- `ShareItem(...)` now returns `ItemShare` instead of `void`.

Expand Down
7 changes: 0 additions & 7 deletions TODO.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion docfx/docs/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Quick start

> Starting with the next x.x.x release, `ShareItem(...)` returns `ItemShare` instead of `void`.
> Starting with 2.5.0, `ShareItem(...)` returns `ItemShare` instead of `void`.

### Creating an instance of the manager

Expand Down
Loading