Skip to content

build(deps): bump the maven-deps group across 2 directories with 1 update - #670

Merged
olleolleolle merged 2 commits into
masterfrom
dependabot/maven/integration/rails7_test/maven-deps-5c89ab620c
Oct 13, 2026
Merged

olleolleolle merged 2 commits into
masterfrom
dependabot/maven/integration/rails7_test/maven-deps-5c89ab620c

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 9, 2026

Copy link
Copy Markdown
Contributor

Bumps the maven-deps group with 1 update in the /integration/rails7_test directory: org.eclipse.jetty.ee11:jetty-ee11-maven-plugin.
Bumps the maven-deps group with 1 update in the /integration/simple_rack_test directory: org.eclipse.jetty.ee11:jetty-ee11-maven-plugin.

Updates org.eclipse.jetty.ee11:jetty-ee11-maven-plugin from 12.1.13 to 12.1.14

Updates org.eclipse.jetty.ee11:jetty-ee11-maven-plugin from 12.1.13 to 12.1.14

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

…date

Bumps the maven-deps group with 1 update in the /integration/rails7_test directory: org.eclipse.jetty.ee11:jetty-ee11-maven-plugin.
Bumps the maven-deps group with 1 update in the /integration/simple_rack_test directory: org.eclipse.jetty.ee11:jetty-ee11-maven-plugin.


Updates `org.eclipse.jetty.ee11:jetty-ee11-maven-plugin` from 12.1.13 to 12.1.14

Updates `org.eclipse.jetty.ee11:jetty-ee11-maven-plugin` from 12.1.13 to 12.1.14

---
updated-dependencies:
- dependency-name: org.eclipse.jetty.ee11:jetty-ee11-maven-plugin
  dependency-version: 12.1.14
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: maven-deps
- dependency-name: org.eclipse.jetty.ee11:jetty-ee11-maven-plugin
  dependency-version: 12.1.14
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: maven-deps
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 9, 2026
@olleolleolle

olleolleolle commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Right, #668 did work, not long ago, it’s not the change, it’s something else.

Looked at 9.4 an integration test, it had: 'jruby-rack 1.2’ (All those failed.)

[INFO] Gem::MissingSpecError: Could not find 'rack' (~> 2.2.0) among 75 total gem(s)

EDIT: Turned out to be a dependency missing due ordering of jobs expectation.

In the failing run, simple_rack_test ran first and the gem home had no rack yet.

simple_rack_test packages rack ~> 2.2.0 via config/warble.rb, but never
installed it. With jruby-rack 1.3/2.0 it arrives as a dependency; jruby-rack
1.2 has none, so the test only passed when rails7_test happened to run first
and bundle-install rack into the shared gem home. The invoker plugin's
directory order is not stable, so the jruby-rack 1.2 integration jobs failed
with Gem::MissingSpecError when simple_rack_test ran first.
@olleolleolle

Copy link
Copy Markdown
Member

cc @chadlwilson I added a direct gem install, to make simple_rack_test behave, in all orderings of jobs. I intend to merge this.

@olleolleolle
olleolleolle merged commit 0c49051 into master Oct 13, 2026
23 checks passed
@dependabot
dependabot Bot deleted the dependabot/maven/integration/rails7_test/maven-deps-5c89ab620c branch October 13, 2026 11:00
@chadlwilson

Copy link
Copy Markdown
Contributor

Thx!

While the dependencies were not right, so needed fixing somehow, this is probably also because of changes in Maven 3.9.16 -> 3.10.0 which has automatically been picked up by the GHA runner since the last successful build, and is actually quite a decent size change.

Since I removed Mavenfile complexity recently, i can change this to use mvnw for build determinisim now, which would avoid this in future (other jruby projects typically use mvnw these days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants