jquery: Address link text overflow issue on meetings.jquery.org #483
Conversation
Fixed the issue of hyperlinks exceeding the screen in meetings.jquery.org.
修复jquery.org下二级域名的导航栏会将域名指向jquery.org而不是jquery.com的问题
themes/jquery/menu-header.php
Outdated
| function menu_header_jquery_org() { | ||
| return array( | ||
| 'https://jquery.org/' => 'Home', | ||
| 'https://jquery.com/' => 'Home', |
There was a problem hiding this comment.
Neither org nor home make sense to me here... jquery.org no longer has a home page, and jquery.com is a different site. I'd rather remove this link altogether.
There was a problem hiding this comment.
Removing the hyperlink from .org means mobile users won't be able to access the jquery.com main page through a prominent shortcut because #global-nav is hidden on mobile devices. Do we really want to do this?
I have a few other questions:
- In the PC UI, the Events section of global-nav no longer points to https://events.jquery.org/. Should it be removed?
- Under menu_header_jquery_org, Support and Team point to https://jquery.org/support/ and https://jquery.org/team/ respectively, and then redirect to https://jquery.com/support/ and https://jquery.com/team/. Should these be replaced with the final domain names?
There was a problem hiding this comment.
.org is intentional and should stay. The jQuery Foundation has become the OpenJS Foundation and the redirect reflects that.
There was a problem hiding this comment.
.orgis intentional and should stay. The jQuery Foundation has become the OpenJS Foundation and the redirect reflects that.
Does this mean that existing links don't need to be changed?
There was a problem hiding this comment.
Does this mean that existing links don't need to be changed?
Correct. I like the word-break change, though.
There was a problem hiding this comment.
@timmywil should we then maybe just change the link to point to https://openjsf.org/ directly, saving the redirect? In most other places we link directly, I think.
There was a problem hiding this comment.
I kind of prefer the redirect. I see it as more historical, but it's not a big preference.
There was a problem hiding this comment.
@timmywil in many content repos (although not in this one) we have a spider check workflow which fails if any link redirects. So we actually make sure in CI that we're linking directly. One of the reasons is perhaps that redirects slows down users.
HermitShamiko
changed the title
timmywil
changed the title
timmywil
changed the title
3 participants
1.Attempted fixed an issue where hyperlink text in the category logs of meetings.jquery.org would overflow on mobile devices.
@mgol @timmywil