Repository navigation
A round frozen by a focus loss resumes behind a breather - #51
Merged
Merged
Conversation
The phone stops updating the game while its window has no focus (the notification shade, a call, another split-screen pane), so a round is not lost unattended. When the focus came back the round went on from the very next frame: a bomb frozen a few pixels above the ship landed before the player's finger and eyes were back on the game. Handing the game back from the glasses already covers that moment with the usual post-hit breather; the focus return now gets the same one, also for a round paused under Settings, and never on the title or an end screen. Three host-run tests cover it (two fail without the change); 155 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone stops updating the game while its window has no focus (the
notification shade, a call, another split-screen pane), so a round is
not lost unattended. When the focus came back the round went on from the
very next frame: a bomb frozen a few pixels above the ship landed before
the player's finger and eyes were back on the game. Handing the game
back from the glasses already covers that moment with the usual post-hit
breather; the focus return now gets the same one, also for a round
paused under Settings, and never on the title or an end screen.
Three host-run tests cover it (two fail without the change); 155 tests.