Repository navigation
The phone game runs immersive: the navigation bar no longer covers the control strip - #50
Merged
Merged
Conversation
…e control strip With targetSdk 35 and later the window spans the whole display, and the launcher activity was the plain NativeActivity with a theme that only hid the status bar. On a phone with 3-button navigation the bar sat over the bottom of the control strip, so taps there went to Back, Home and Recents instead of the ship; with gesture navigation a drag that started in the gesture band went to the home gesture. The launcher is now GameActivity, a NativeActivity subclass that hides the system bars and lets a swipe from the edge show them briefly, the way the glasses activity already subclasses it to keep its screen on. The smoke test launches it and asserts that the navigation bar is hidden and the bottom inset is zero once the first frame is presented; the CI multi-runs, the replay script and the README launch it by its new name. A home-screen shortcut made for the old component name needs to be made again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With targetSdk 35 and later the window spans the whole display, and the
launcher activity was the plain NativeActivity with a theme that only
hid the status bar. On a phone with 3-button navigation the bar sat
over the bottom of the control strip, so taps there went to Back, Home
and Recents instead of the ship; with gesture navigation a drag that
started in the gesture band went to the home gesture.
The launcher is now GameActivity, a NativeActivity subclass that hides
the system bars and lets a swipe from the edge show them briefly, the
way the glasses activity already subclasses it to keep its screen on.
The smoke test launches it and asserts that the navigation bar is
hidden and the bottom inset is zero once the first frame is presented;
the CI multi-runs, the replay script and the README launch it by its
new name. A home-screen shortcut made for the old component name needs
to be made again.