Repository navigation
The breather and the save also apply to a round paused under Settings; a wave wider than the window holds instead of raining down - #48
Merged
Conversation
…; a wave wider than the window holds instead of raining down The hand-back breather was granted only while the game was in PLAYING, but the phone's only way to bring the game back from the glasses is the GLASSES row inside Settings, so the phone instance was in SETTINGS at that moment and got no grace: the bombs frozen mid-air landed as soon as the player pressed BACK. The paused state now looks through Settings to the round behind it. For the same reason a round paused under Settings was not considered mid-game, so a process killed in the background while the overlay was open lost the run. isMidGame and saveLevel look through Settings too, and a pause during the level-clear interlude saves the next level. In a window narrower than the wave (a tall free-form window, a fold's outer panel) both edge tests were true on alternate frames, so the wave flipped and stepped down every frame and reached the invasion line in half a second. A wave that cannot fit is held centred instead. Native tests 149 to 152.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-back breather was granted only while the game was in PLAYING,
but the phone's only way to bring the game back from the glasses is
the GLASSES row inside Settings, so the phone instance was in SETTINGS
at that moment and got no grace: the bombs frozen mid-air landed as
soon as the player pressed BACK. The paused state now looks through
Settings to the round behind it.
For the same reason a round paused under Settings was not considered
mid-game, so a process killed in the background while the overlay was
open lost the run. isMidGame and saveLevel look through Settings too,
and a pause during the level-clear interlude saves the next level.
In a window narrower than the wave (a tall free-form window, a fold's
outer panel) both edge tests were true on alternate frames, so the wave
flipped and stepped down every frame and reached the invasion line in
half a second. A wave that cannot fit is held centred instead.
Native tests 149 to 152.