Repository navigation
Settings saved by one instance reach the other without a focus event - #45
Merged
Merged
Conversation
The settings file was only re-read on a window-focus event, and the projected window the glasses instance draws into never receives one, so Sound or Auto Play toggled on the phone while the game ran on the glasses stayed as they were there until that activity was recreated. The two instances live in one process: every save now bumps a shared generation counter and an instance whose last load is behind it reloads on its next frame, music flag included. New test: two instances on one data path; a row toggled on the phone is seen by the other after a frame, with no focus event. 146 -> 147 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings file was only re-read on a window-focus event, and the
projected window the glasses instance draws into never receives one, so
Sound or Auto Play toggled on the phone while the game ran on the glasses
stayed as they were there until that activity was recreated. The two
instances live in one process: every save now bumps a shared generation
counter and an instance whose last load is behind it reloads on its next
frame, music flag included.
New test: two instances on one data path; a row toggled on the phone is
seen by the other after a frame, with no focus event. 146 -> 147 tests.