Repository navigation
Inert phone taps on the glasses, a cancel is not a tap, save the next level - #44
Merged
Merged
Conversation
… level While a game runs on the glasses the phone shows a hand-off banner over its title or end screen, but a tap on that banner still started a game (hidden, frozen, waiting for the hand-back) or dismissed the end screen. Those taps are now ignored while handed off; Settings stays reachable through the gear and its rows keep working, including the one that hands the game back. A gesture the system takes away (an edge swipe for back or recents) arrives as a pointer down followed by a cancel; the cancel cleared the fingers but left the pending tap, so the next frame started a game or dismissed a screen. The cancel now drops the tap too. A saved session taken during the level-clear interlude named the level just cleared, whose bonus was already banked, so restoring replayed the wave and paid the bonus twice. saveLevel() names the next level in that state and the activity saves that. Four new tests (each fails without its fix): a cancelled gesture is not a tap, the phone title tap and end screen are inert while on the glasses, a level clear saves the next level. README 142 -> 146 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a game runs on the glasses the phone shows a hand-off banner over
its title or end screen, but a tap on that banner still started a game
(hidden, frozen, waiting for the hand-back) or dismissed the end screen.
Those taps are now ignored while handed off; Settings stays reachable
through the gear and its rows keep working, including the one that
hands the game back.
A gesture the system takes away (an edge swipe for back or recents)
arrives as a pointer down followed by a cancel; the cancel cleared the
fingers but left the pending tap, so the next frame started a game or
dismissed a screen. The cancel now drops the tap too.
A saved session taken during the level-clear interlude named the level
just cleared, whose bonus was already banked, so restoring replayed the
wave and paid the bonus twice. saveLevel() names the next level in that
state and the activity saves that.
Four new tests (each fails without its fix): a cancelled gesture is not
a tap, the phone title tap and end screen are inert while on the glasses,
a level clear saves the next level. README 142 -> 146 tests.