Repository navigation
Tests: when the music plays - #41
Merged
Merged
Conversation
The test audio stub now records the music flag the game pushes, and six Google Test cases pin down syncMusic: silent on the title and playing in a round, still playing under Settings opened from a round, stopped while Sound is off and back when it is on again, stopped on the phone while the glasses play the round and back when they stop, kept on the glasses instance itself, and no engine means no calls. The audio paths were never exercised before: every test ran without an engine attached. Verified on the host: 125 tests pass. The README test count will be updated once the open test PRs have landed.
Keeps the high-score file tests and the music tests, and sets the README suite count to the 128 tests the host run reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test audio stub now records the music flag the game pushes, and six Google Test cases pin down
syncMusic: silent on the title and playing in a round, still playing under Settings opened from a round, stopped while Sound is off and back when it is on again, stopped on the phone while the glasses play the round and back when they stop, kept on the glasses instance itself, and no engine means no calls. The audio paths were never exercised before: every test ran without an engine attached.Verified on the host: 125 tests pass. The README test count will be updated once the open test PRs have landed, so they do not fight over the same line.