Skip to content

Reactor as member should be a ref#199

Merged
mrabine merged 2 commits into
mainfrom
class-should-use-ref-for-reactor-member
May 15, 2026
Merged

Reactor as member should be a ref#199
mrabine merged 2 commits into
mainfrom
class-should-use-ref-for-reactor-member

Conversation

@mrabine
Copy link
Copy Markdown
Collaborator

@mrabine mrabine commented May 15, 2026

No description provided.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 15, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage 96.67% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation
Diff coverage 96.67% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (882e8e0) 11668 11283 96.70%
Head commit (05f7cc8) 11670 (+2) 11285 (+2) 96.70% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#199) 30 29 96.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.72%. Comparing base (882e8e0) to head (05f7cc8).

Files with missing lines Patch % Lines
fabric/include/join/resolver.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          93       93           
  Lines       10952    10952           
=======================================
  Hits        10593    10593           
  Misses        359      359           
Flag Coverage Δ
unittests 96.72% <96.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

coveralls commented May 15, 2026

Coverage Report for CI Build 25917235817

Coverage remained the same at 96.701%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 uncovered change across 1 file (29 of 30 lines covered, 96.67%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
fabric/include/join/resolver.hpp 4 3 75.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11670
Covered Lines: 11285
Line Coverage: 96.7%
Coverage Strength: 112934.07 hits per line

💛 - Coveralls

@mrabine mrabine merged commit 0a8cf28 into main May 15, 2026
14 of 15 checks passed
@mrabine mrabine deleted the class-should-use-ref-for-reactor-member branch May 15, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants