Skip to content

Conversation

@Wolfy76700
Copy link
Collaborator

@Wolfy76700 Wolfy76700 commented May 11, 2025

image

@ZombieHDGaming ZombieHDGaming merged commit 51b6fd3 into joaorb64:main May 19, 2025
@Wolfy76700 Wolfy76700 deleted the feature/controller branch July 7, 2025 18:14
@dens0ne
Copy link

dens0ne commented Oct 3, 2025

This is cool, I am trying to use it in OBS. So far I don't see it integrated in JS files in layout which I am doing, is that the right thing to do?

I'm doing the following in the index.js file of the versus_screen layout

SetInnerHtml(
            $(`.p${t + 1} .controller`),
            player.controller.icon_path
              ? `
              <div>
                  <div class='controller'>
                  <img src='../../${player.controller.icon_path}' width="50" height="50">
                  </div>
              </div>`
              : ""
          );

then in add the following in a .html file both for p1 and p2

<div class="controller"></div>

So far it is working

image

@Wolfy76700
Copy link
Collaborator Author

Yeah we didn't get to the layouts yet, we need to work on that ^^

@dens0ne
Copy link

dens0ne commented Oct 3, 2025

We could help with that, I mean it is mostly just copying and pasting this same snippet in different js files right?

@Wolfy76700
Copy link
Collaborator Author

That, IMO the VS screens should all have it with both the image itself and the name being displayed

@Wolfy76700
Copy link
Collaborator Author

Also in case you need it we just merged a couple of controller-related features on the beta branch which may help, including exporting the icons' sizes: #901

And I added a couple of generic options for mouse and keyboard, but feel free to contribute to the controller repo if you want to add more controllers: TournamentStreamHelper/ControllerDatabase#36

@dens0ne
Copy link

dens0ne commented Oct 4, 2025

We didn't want to overcomplicate things in our end so we created a generic pad item that we'll be using, but you guys LMK if you think it is worthwile pushing that as a controller. Since we run fighting games tournaments, we only care about generic leverless, generic fightstick, and generic pad

@Wolfy76700
Copy link
Collaborator Author

Wolfy76700 commented Oct 4, 2025

I think having a generic pad would be good, as well as a generic of every other category, just to at least cover the basic use cases. Having more detailed controller descriptions can come later ^^

(Note to myself: I need to add a steering wheel category at some point)

@dens0ne
Copy link

dens0ne commented Oct 5, 2025

Here is an example of how it could look in versus with the name added (front end is definitely not my thing). If something like that is ok for now, we can at open a PR with the code

image

@Wolfy76700
Copy link
Collaborator Author

Feel free to open a PR, I'll probably merge it when the new version releases. In the meantime I added an export of image dimensions to the beta, to help with ensuring the aspect ratio of the images stays correct. (Similar to what we did with variants most notably)

@dens0ne
Copy link

dens0ne commented Oct 12, 2025

TournamentStreamHelper/TournamentStreamHelper-layouts#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants