-
Notifications
You must be signed in to change notification settings - Fork 56
Added support for controller data #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yeah we didn't get to the layouts yet, we need to work on that ^^ |
|
We could help with that, I mean it is mostly just copying and pasting this same snippet in different js files right? |
|
That, IMO the VS screens should all have it with both the image itself and the name being displayed |
|
Also in case you need it we just merged a couple of controller-related features on the beta branch which may help, including exporting the icons' sizes: #901 And I added a couple of generic options for mouse and keyboard, but feel free to contribute to the controller repo if you want to add more controllers: TournamentStreamHelper/ControllerDatabase#36 |
|
We didn't want to overcomplicate things in our end so we created a |
|
I think having a generic pad would be good, as well as a generic of every other category, just to at least cover the basic use cases. Having more detailed controller descriptions can come later ^^ (Note to myself: I need to add a steering wheel category at some point) |
|
Feel free to open a PR, I'll probably merge it when the new version releases. In the meantime I added an export of image dimensions to the beta, to help with ensuring the aspect ratio of the images stays correct. (Similar to what we did with variants most notably) |


Uh oh!
There was an error while loading. Please reload this page.