Repository navigation
Play page exits and entrances together - #210
Merged
Merged
Conversation
The old board finished leaving before the next node arrived, so the frame went empty. Fade, slide, rise, and zoom now share one timed_play that lasts as long as those two steps did. Co-authored-by: John Menke <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between pages, the previous board and the next page's first node now move in the same play, so the frame does not go empty between them. Later boxes stay paced to the narration. The shared play lasts as long as the old exit plus the old entrance, so the clock budget is unchanged.
layout.page_transition(or a per-pagetransition):fade— crossfade. Still the default.slide— the board travels left while the next node enters from the right.rise— the board drops while the next node settles from just under the title.zoom— the board shrinks while the next node scales up.none— instant remove, then the next reveal.An explicit box
revealon that first incoming node still plays after the exit.Existing bundles pick this up on the next
scene-compile.docgen benchmarkstill meetsbaseline.json.Mid-handoff
The old board and the new node are on screen together.
Slide midpoint: Plan leaving left while Ship arrives from the right
Rise midpoint: Ship settling under the title while Plan and Build drop
Zoom midpoint: Ship scaling up while Plan and Build shrink
CrossSlide-handoff.mp4
To show artifacts inline, enable in settings.