feat(rotor): make Kafka client logging and librdkafka debug configurable - #1453
Open
tevaum wants to merge 1 commit into
Open
feat(rotor): make Kafka client logging and librdkafka debug configurable#1453tevaum wants to merge 1 commit into
tevaum wants to merge 1 commit into
Conversation
tevaum
marked this pull request as ready for review
August 11, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
KAFKA_DEBUG(librdkafkadebugfacilities, e.g.cgrp,fetch,broker) andKAFKA_CLIENT_LOG_LEVELlogCreatorthat was left commented out inkafka-config.ts, so client/librdkafka messages reach rotor's logger with their facility tagbuildKafkaConfig/kafkaClientLogLeveland cover them with unit testsWhy
Rotor pins the Kafka client to
logLevel: ERRORwith nologCreator, and exposes no way to passlibrdkafka options, so client-side diagnostics are unreachable in a deployed rotor. When a consumer
stops delivering records but stays a live group member (see
confluentinc/confluent-kafka-javascript#476 and #497), rotor logs nothing at all and there is no
supported way to collect the
cgrp/fetchoutput a maintainer needs to diagnose it.Defaults are unchanged: without the new variables the client still logs at
ERRORand nodebugkey is set. Note all three levels must align to see librdkafka output —
KAFKA_DEBUG=cgrp,fetch,KAFKA_CLIENT_LOG_LEVEL=debug, andJUAVA_LOG_LEVEL=debug.translateLevelalready existed but was unreferenced; this makes it live.